#11483 closed enhancement (fixed)
enable abs_integrate package from maxima
Reported by: | Karl-Dieter Crisman | Owned by: | Burcin Erocal |
---|---|---|---|
Priority: | major | Milestone: | sage-5.0 |
Component: | calculus | Keywords: | |
Cc: | Burcin Erocal, Jason Grout | Merged in: | sage-5.0.beta3 |
Authors: | Michael Orlitzky, Jason Grout | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #12094 | Stopgaps: |
Attachments (1)
Change History (14)
comment:1 Changed 11 years ago by
comment:3 Changed 11 years ago by
See this sage-devel discussion for someone working on this!
Also, see #11966 for a newer spkg to base upon.
comment:4 Changed 11 years ago by
Dependencies: | → #12094 |
---|
Here's my shot at this. There's one regression (a Maxima bug) that's fixed by Maxima 5.24.0, thus the dependency.
comment:5 Changed 11 years ago by
Status: | new → needs_review |
---|
comment:6 Changed 11 years ago by
Authors: | → Michael Orlitzky |
---|---|
Reviewers: | → Karl-Dieter Crisman |
Ok, this looks good, and is the proper way to deal with this. All tests pass.
Should we add Jason as an author due to his work at #8624? Up to him, probably.
comment:7 Changed 11 years ago by
Status: | needs_review → needs_work |
---|---|
Work issues: | → commit message, formatting |
Scratch that - Michael, can you update and give a proper commit message etc.? Also, the documentation is incorrectly formatted with double colons etc. - including the zXXX comment, which should have the double colon for EXAMPLES made single and then have a double colon after "subject to change".
Changed 11 years ago by
Attachment: | sage-trac-11483.patch added |
---|
Updated patch addressing reviewer comments.
comment:8 Changed 11 years ago by
Status: | needs_work → needs_review |
---|
That should be a little bit better.
Jason should get author credit too. I unfortunately didn't realize there was a patch at #8624, since it's closed: fixed, until after I had created my patch. Once I saw his, I went back and added some of his doctests to mine.
If he doesn't get author credit, then it looks like I just stole everything =)
comment:9 Changed 11 years ago by
Authors: | Michael Orlitzky → Michael Orlitzky, Jason Grout |
---|---|
Status: | needs_review → positive_review |
In retrospect, I realize that this file (maxima_lib
) isn't even in the reference manual, and it might be nice to have some of these examples in more places (note that x.integrate?
is horrible, though it points to a better place). Anyway, this is all fine now.
comment:10 Changed 11 years ago by
Work issues: | commit message, formatting |
---|
comment:11 Changed 11 years ago by
Merged in: | → sage-5.0.beta3 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
comment:12 Changed 10 years ago by
abs_integrate can't do easy things like integrate(abs(cos(x)),x) right.
(%i8) integrate(abs(cos(x)),x); log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). log: encountered log(0). (%o8) 2*((1/2-sin(x)/((cos(x)+1)*(sin(x)^2/(cos(x)+1)^2+1))) *signum(sin(x)/(cos(x)+1)-1) +1)*signum(sin(x)/(cos(x)+1)+1)
and the resulting expression is wrong, as it is 1 at 0, and not 0. As a result, we get integrate(abs(cos(x)),x,0,pi)==-1
.
Needless to say, same happens in Sage:
sage: integrate(abs(cos(x)),(x,0,pi)) -1
This is with maxima 5.26, as well as with 5.29, see #13364.
comment:13 Changed 8 years ago by
Please don't add to this closed ticket. The current ticket about abs_integrate
is #12731.
This would fix #11594.