Opened 10 years ago

Closed 10 years ago

#11480 closed enhancement (fixed)

ZigZag and rational (canonical) forms

Reported by: rbeezer Owned by: jason, was
Priority: major Milestone: sage-4.7.2
Component: linear algebra Keywords: sd31
Cc: ddrake Merged in: sage-4.7.2.alpha2
Authors: Rob Beezer Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11356 Stopgaps:

Status badges

Description (last modified by rbeezer)

For matrices, ZigZag form is a precursor for a computation of the rational canonical form (and interesting in its own right). Then we get rational form also, a canonical form computable over any field, which will make is_similar() bullet-proof.

Apply:

  1. trac_11480_zigzag_rational_forms.patch

Depends:

  1. #11356

Attachments (1)

trac_11480_zigzag_rational_forms.patch (48.4 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by rbeezer

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc ddrake added
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by rbeezer

  • Dependencies set to #11356
  • Description modified (diff)
  • Keywords sd31 added

comment:3 follow-up: Changed 10 years ago by davidloeffler

  • Reviewers set to David Loeffler
  • Status changed from needs_review to positive_review

Great stuff! Code looks really sound, all doctests pass, and I tried a bunch of random corner cases and it coped with all of them gracefully. Positive review.

comment:4 in reply to: ↑ 3 Changed 10 years ago by rbeezer

Replying to davidloeffler:

Great stuff!

Hi David,

Yes, this was a fun one. And I plan to stitch it into .is_similar() to make that bullet-proof.

I was secretly hoping you were headed to this one after taking care of the companion matrix constructor. Thanks very much for looking it over and carefully putting it through its paces.

Rob

comment:5 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.7.1 to sage-4.7.2

comment:6 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.