Opened 10 years ago

Closed 9 years ago

#11471 closed enhancement (invalid)

Add i18n capabilities to the Flask notebook

Reported by: mhansen Owned by: jason, mpatel, was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords:
Cc: ddrake, aquino.luizclaudio@…, robert.marik, jason Merged in:
Authors: Reviewers: Keshav kini, Luiz Aquino, Dan Drake, Tim Dumol, Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (1)

trac_11471.patch (452.4 KB) - added by mhansen 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by mhansen

  • Authors set to Luiz Aquino, Dan Drake, Tim Dumol, Mike Hansen

This is a port of the code at #9428 to the Flask notebook. The code should be a bit cleaner (not having to pass around username everywhere). This should apply on top of http://code.google.com/r/rkirov-flask/ (changeset 503:79b88d03adf0).

comment:2 Changed 10 years ago by mhansen

  • Component changed from PLEASE CHANGE to notebook
  • Owner changed from tbd to jason, mpatel, was
  • Type changed from PLEASE CHANGE to enhancement

Changed 10 years ago by mhansen

comment:3 Changed 10 years ago by rkirov

hmmm, i am getting "ImportError?: No module named i18n" after installing babel and flask-babel.

Is this a python package or a missing file?

comment:4 Changed 10 years ago by mhansen

It's a import that shouldn't be there.

comment:5 Changed 9 years ago by jason

  • Cc jason added

Do you know offhand if this was merged into the sage notebook?

comment:6 Changed 9 years ago by kini

  • Status changed from new to needs_review

Yes, in this commit.

comment:7 Changed 9 years ago by kini

  • Reviewers set to Keshav kini
  • Status changed from needs_review to positive_review

comment:8 Changed 9 years ago by kini

  • Milestone changed from sage-5.1 to sage-duplicate/invalid/wontfix

comment:9 Changed 9 years ago by jdemeyer

  • Authors Luiz Aquino, Dan Drake, Tim Dumol, Mike Hansen deleted
  • Resolution set to invalid
  • Reviewers changed from Keshav kini to Keshav kini, Luiz Aquino, Dan Drake, Tim Dumol, Mike Hansen
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.