Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11449 closed defect (fixed)

Do not make sage-env executable

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-4.7.1
Component: scripts Keywords:
Cc: iandrus Merged in: sage-4.7.1.alpha4
Authors: Jeroen Demeyer Reviewers: Mariah Lenox
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage-make_devel_packages should not make sage-env executable. Merged ticket #10469 changed the permissions of sage-env to non-executable and sage-make_devel_packages should be changed accordingly.

Attachments (1)

11449.patch (673 bytes) - added by jdemeyer 11 years ago.
SCRIPTS patch

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by jdemeyer

SCRIPTS patch

comment:1 Changed 11 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 follow-up: Changed 11 years ago by kini

Er, why is sage-make_devel_packages modifying permissions on these files anyway (lines 139-141)? Aren't they already all tracked by the $SAGE_ROOT/local/bin repository?

comment:3 in reply to: ↑ 2 Changed 11 years ago by jdemeyer

Replying to kini:

Er, why is sage-make_devel_packages modifying permissions on these files anyway (lines 139-141)? Aren't they already all tracked by the $SAGE_ROOT/local/bin repository?

I also wondered about that. Since I don't really know why, I decided to leave those chmods in. In any case, that can be dealt with on a different ticket.

comment:4 Changed 11 years ago by kini

Well, this is a mystery for sage-devel. I posted there. Hopefully we can just get rid of that in this patch - there's no reason to make two patches for such closely related issues, and over only three lines of code, IMO...

comment:5 Changed 11 years ago by iandrus

  • Cc iandrus added

comment:6 Changed 11 years ago by mariah

  • Reviewers set to Mariah Lenox
  • Status changed from needs_review to positive_review

Applied patch to sage-4.7.1.alpha2, did 'sage -sdist', built and tested source with 'make testlong'. All tests passed. Positive review!

comment:7 follow-up: Changed 11 years ago by kini

Thanks for taking the time to do that! Can we resolve the other issue as well? Or should I make a new ticket about it?

comment:8 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha4
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 in reply to: ↑ 7 Changed 11 years ago by jdemeyer

Replying to kini:

Thanks for taking the time to do that! Can we resolve the other issue as well? Or should I make a new ticket about it?

I think that should be on a different ticket.

comment:10 Changed 11 years ago by kini

It is now #11492.

Note: See TracTickets for help on using tickets.