Opened 12 years ago
Closed 12 years ago
#11430 closed defect (fixed)
is_pseudoprime_small_power has bugs with get_data=True
Reported by: | itolkov | Owned by: | itolkov |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7.1 |
Component: | basic arithmetic | Keywords: | |
Cc: | Merged in: | sage-4.7.1.alpha4 | |
Authors: | Igor Tolkov | Reviewers: | Mariah Lenox |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
sage: is_pseudoprime_small_power(31^2, get_data=True) [(31, 2)] sage: is_pseudoprime_small_power(31, get_data=True) True
Also, code can be written much better.
Attachments (2)
Change History (8)
Changed 12 years ago by
Attachment: | 11430-arith.patch added |
---|
comment:1 Changed 12 years ago by
Status: | new → needs_review |
---|
comment:2 Changed 12 years ago by
Priority: | minor → major |
---|
comment:3 Changed 12 years ago by
Status: | needs_review → needs_work |
---|
Needs a proper commit message. See http://www.sagemath.org/doc/developer/walk_through.html#submitting-a-change.
Changed 12 years ago by
Attachment: | trac_11430_pseudoprime.patch added |
---|
Updated with commit message, do not use 11430-arith.patch
comment:5 Changed 12 years ago by
Authors: | → Igor Tolkov |
---|---|
Description: | modified (diff) |
Reviewers: | → Mariah Lenox |
Status: | needs_review → positive_review |
I applied the patch to sage-4.7.1.alpha2, did 'sage -b', and verified that the patch fixed the reported problem. I then did 'make testlong'. All tests passed. Positive review!
comment:6 Changed 12 years ago by
Merged in: | → sage-4.7.1.alpha4 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Timing (ispsp is a more compact version, ispsp2 is this version, is_pseudoprime_small_power is the current version):