Add normalization to clonable lists

[hivert]

The patch adds a new support class in list_clone.pyx for lists with a normalization methods. The normalization method is called both after creation and clone/modification. This will be needed for rooted trees.

I also take the opportunity of cleaning up the bad usage of assert in the examples and replaced them by if ... : raise ValueError.

Apply

• trac_11407-list_clone_improve-fh.patch​

[hivert]

I just pushed a new patch which fixes the failing doctests

[davidloeffler]

Patch does not apply to 5.0.beta11, I'm afraid

[nborie]

Message for Florent:

For information, your patch does not commute with mine about enumeration modulo the action of a permgroup. I try to push back my patch in the queue but i didn't manage to do it without breaking the queue... Sorry for that...

[chapoton]

Hello Florent,

I rebased the patch on 5.8 but then sage fails to compile with the following messages.

sage/structure/list_clone.pyx:1826:10: Overriding final methods is not allowed

sage/structure/list_clone.pyx:1826:10: Only final types can have final Python (def/cpdef) methods

It seems that the problem is with the __exit__ method.

[chapoton]

for the bot

apply trac_11407-list_clone_improve-fh.patch

[tscrim]

Hey Florent,

Looks good minus the one missed change in the review patch I've uploaded. After you give it a quick check, and you set this to positive review.

Best,
Travis

For patchbot:

Apply: trac_11407-list_clone_improve-fh.patch trac_11407-review-ts.patch

[hivert]

Hi travis,

I folded your patch and fixed the multiline doctests. I'm ok with you changes so please doublecheck and se positive review if everything is ok.

Florent

[tscrim]

Looks good to me. Thanks Florent.

For patchbot:

Apply: trac_11407-list_clone_improve-fh.patch

[hivert]

Thanks for the review.

Cheers,

Florent