Opened 11 years ago
Closed 9 years ago
#11407 closed enhancement (fixed)
Add normalization to clonable lists
Reported by: | hivert | Owned by: | hivert |
---|---|---|---|
Priority: | major | Milestone: | sage-5.12 |
Component: | combinatorics | Keywords: | clone normalization Cernay2012, days49 |
Cc: | sage-combinat, tscrim | Merged in: | sage-5.12.beta2 |
Authors: | Florent Hivert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11308 | Stopgaps: |
Description (last modified by )
The patch adds a new support class in list_clone.pyx
for lists with a normalization methods. The normalization method is called both after creation and clone/modification. This will be needed for rooted trees.
I also take the opportunity of cleaning up the bad usage of assert
in
the examples and replaced them by if ... : raise ValueError
.
Apply
Attachments (3)
Change History (21)
comment:1 Changed 11 years ago by
- Description modified (diff)
comment:2 Changed 11 years ago by
- Dependencies set to #11308
- Description modified (diff)
comment:3 Changed 10 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:4 Changed 10 years ago by
- Keywords Cernay2012 added
comment:5 Changed 10 years ago by
comment:6 Changed 10 years ago by
- Status changed from needs_review to needs_work
- Work issues set to rebase to current beta
Patch does not apply to 5.0.beta11, I'm afraid
comment:7 Changed 10 years ago by
Message for Florent:
For information, your patch does not commute with mine about enumeration modulo the action of a permgroup. I try to push back my patch in the queue but i didn't manage to do it without breaking the queue... Sorry for that...
comment:8 Changed 9 years ago by
Hello Florent,
I rebased the patch on 5.8 but then sage fails to compile with the following messages.
sage/structure/list_clone.pyx:1826:10: Overriding final methods is not allowed sage/structure/list_clone.pyx:1826:10: Only final types can have final Python (def/cpdef) methods
It seems that the problem is with the __exit__
method.
Changed 9 years ago by
comment:9 Changed 9 years ago by
- Description modified (diff)
comment:10 Changed 9 years ago by
- Cc tscrim added
- Description modified (diff)
- Keywords days49 added
- Status changed from needs_work to needs_review
- Work issues rebase to current beta deleted
comment:11 Changed 9 years ago by
for the bot
apply trac_11407-list_clone_improve-fh.patch
Changed 9 years ago by
comment:12 Changed 9 years ago by
- Description modified (diff)
- Reviewers set to Travis Scrimshaw
Hey Florent,
Looks good minus the one missed change in the review patch I've uploaded. After you give it a quick check, and you set this to positive review.
Best,
Travis
For patchbot:
Apply: trac_11407-list_clone_improve-fh.patch trac_11407-review-ts.patch
Changed 9 years ago by
comment:13 Changed 9 years ago by
- Description modified (diff)
comment:14 Changed 9 years ago by
Hi travis,
I folded your patch and fixed the multiline doctests. I'm ok with you changes so please doublecheck and se positive review if everything is ok.
Florent
comment:15 Changed 9 years ago by
- Status changed from needs_review to positive_review
Looks good to me. Thanks Florent.
For patchbot:
Apply: trac_11407-list_clone_improve-fh.patch
comment:16 Changed 9 years ago by
Thanks for the review.
Cheers,
Florent
comment:17 Changed 9 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:18 Changed 9 years ago by
- Merged in set to sage-5.12.beta2
- Resolution set to fixed
- Status changed from positive_review to closed
I just pushed a new patch which fixes the failing doctests