Some other embeddings for graph generators

[ncohen]

I wrote #11397 because I needed it, but as some other embeddings really looked alike, it would have been stupid not to fix them too :-)

Apply:

• trac_11399.patch​
• trac_11399-cube.patch​

Nathann

[rbeezer]

Nicer still.

Builds, applies, and performs nicely on 4.7.

I'm going to run tests, since it seems the patchbot has not done its thing yet, and then will flip this to positive review.

Do we now have all the Platonic solids embedded properly?

Rob

[ncohen]

Do we now have all the Platonic solids embedded properly?

Hem... We are missing the .... cube :-D

I just wrote the embedding, but I wondered : is it better to append it to this patch, or to create another one ? :-)

Writing the cube's embedding is so much less interesting than the dodecahedron's ^^;

Nathann

[rbeezer]

Replying to ncohen:

I just wrote the embedding, but I wondered : is it better to append it to this patch, or to create another one ? :-)

Either way, I guess. If I don't get to it today, it might sit until Sage Days (which perhaps argues for another ticket?).

[ncohen]

It was indeed a stupid question :-)

Nathann

[rbeezer]

Got it. Cube looks good as well. Passes long tests, applies to 4,7, etc, etc.

Thanks for filling in these details, or perhaps I should say,

"Thank-yoooouuuu!!!!!!!!!!!!!!!" :-)