Opened 8 years ago
Closed 8 years ago
#11399 closed enhancement (fixed)
Some other embeddings for graph generators
Reported by: | ncohen | Owned by: | jason, ncohen, rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7.1 |
Component: | graph theory | Keywords: | |
Cc: | rbeezer | Merged in: | sage-4.7.1.alpha3 |
Authors: | Nathann Cohen | Reviewers: | Rob Beezer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
I wrote #11397 because I needed it, but as some other embeddings really looked alike, it would have been stupid not to fix them too :-)
Apply:
Nathann
Attachments (2)
Change History (11)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
Changed 8 years ago by
comment:2 follow-up: ↓ 4 Changed 8 years ago by
- Description modified (diff)
- Reviewers set to Rob Beezer
comment:3 Changed 8 years ago by
- Status changed from needs_review to positive_review
comment:4 in reply to: ↑ 2 ; follow-up: ↓ 5 Changed 8 years ago by
Do we now have all the Platonic solids embedded properly?
Hem... We are missing the .... cube :-D
I just wrote the embedding, but I wondered : is it better to append it to this patch, or to create another one ? :-)
Writing the cube's embedding is so much less interesting than the dodecahedron's ^^;
Nathann
comment:5 in reply to: ↑ 4 Changed 8 years ago by
Replying to ncohen:
I just wrote the embedding, but I wondered : is it better to append it to this patch, or to create another one ?
:-)
Either way, I guess. If I don't get to it today, it might sit until Sage Days (which perhaps argues for another ticket?).
Changed 8 years ago by
comment:6 Changed 8 years ago by
- Description modified (diff)
- Status changed from positive_review to needs_work
It was indeed a stupid question :-)
Nathann
comment:7 Changed 8 years ago by
- Status changed from needs_work to needs_review
comment:8 Changed 8 years ago by
- Status changed from needs_review to positive_review
Got it. Cube looks good as well. Passes long tests, applies to 4,7, etc, etc.
Thanks for filling in these details, or perhaps I should say,
"Thank-yoooouuuu!!!!!!!!!!!!!!!" :-)
comment:9 Changed 8 years ago by
- Merged in set to sage-4.7.1.alpha3
- Resolution set to fixed
- Status changed from positive_review to closed
Nicer still.
Builds, applies, and performs nicely on 4.7.
I'm going to run tests, since it seems the patchbot has not done its thing yet, and then will flip this to positive review.
Do we now have all the Platonic solids embedded properly?
Rob