Changes between Version 18 and Version 20 of Ticket #11379


Ignore:
Timestamp:
07/11/11 03:26:39 (7 years ago)
Author:
rbeezer
Comment:

Sebastien,

Sorry to be so tardy on this one. Really just one "issue" that I think needs attention.

Made a reviewer patch: Changed some module and class links in documentation to be active, fixed a couple minor English language things. Do not list me as an author for these.

The animations are great. Can you do something to mark the end (like a few blank frames, for maybe a half-second)? It goes so fast, it is hard to tell where the start is and where the end is.

Related Questions:

  1. Pentamino 8 (a yellow one) still has a hole in it. Not a big deal, but perhaps a symptom of something that should be done more carefully?
  2. I feel bad to bring this up, since I suggested it. The "size" parameter works fine for 0.5 < size < 1.0. Proably size > 1.0 should raise an error. Below size=0.5 the puzzle pieces seem to break into lots of individual cubes. Also the hole in piece 8 seems to change according to size. So I wonder if these first two items are related.
  3. In the 3D puzzle in the tiling module documentation, there are again holes in the pieces.
  4. Maybe each cube of a piece needs to be shrunk and translated, relative to some anchor point (the "corner" closest to the origin?). I have not looked carefully enough to know if this what needs to be done.

Rob

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11379 – Description

    v18 v20  
    88 1. [attachment:trac_11379_corrections-sl.patch]
    99 1. [attachment:trac_11379_color_issue-sl.patch]
    10 
     10 1. [attachment:trac_11379-reviewer-docs.patch]
    1111For the patchbot:
    1212
    13 Apply trac_11379_quantamino-sl.patch trac_11379_corrections-sl.patch trac_11379_color_issue-sl.patch
     13Apply trac_11379_quantamino-sl.patch trac_11379_corrections-sl.patch trac_11379_color_issue-sl.patch trac_11379-reviewer-docs.patch