Opened 11 years ago
Last modified 11 years ago
#11377 closed enhancement
Clean and harmonize module_list.py — at Version 9
Reported by: | fbissey | Owned by: | GeorgSWeber |
---|---|---|---|
Priority: | critical | Milestone: | sage-4.7.1 |
Component: | build | Keywords: | sd31 |
Cc: | strogdon, robertwb | Merged in: | |
Authors: | François Bissey | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
module_list.py is quite messy in its current state. There are several things that can be done:
- remove the unused debian bits
- we have SAGE_LOCAL and SAGE_INC variables but there use iis not uniform
- we also have numpy_include_dirs, numpy_depends, flint_depends, singular_depends and ginac_depends and most of them are under-used.
In this ticket I remove old debian stuff, use SAGE_INC, SAGE_LOCAL and the other variables in a uniform fashion removing all instances of SAGE_ROOT +/local/... and so on to replace it by the appropriate variable.
Apply:
Change History (11)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Cc strogdon added
comment:3 Changed 11 years ago by
Now that 4.7.1.alpha0 is out this can be reviewed.
comment:4 Changed 11 years ago by
- Status changed from needs_review to needs_work
Looks good to me. But in Sage-4.7.1.alpha2 there were some more extension modules added (under sage.groups.perm_gps.partn_ref). Can you updated your patch for that? I'll review it then asap.
comment:5 Changed 11 years ago by
- Keywords sd31 added
comment:6 Changed 11 years ago by
It is up to date for 4.7.1.alpha2 already. The only possible problems could be with #9989 depending on which one is merged first and whether my suggested changes for it are accepted.
comment:7 Changed 11 years ago by
The patch applies, but sage.groups.perm_gps.partn_ref.*
don't use SAGE_INC
and the flint_depends
:
Extension('sage.groups.perm_gps.partn_ref.automorphism_group_canonical_label', sources = ['sage/groups/perm_gps/partn_ref/automorphism_group_canonical_label.pyx'], libraries = ['gmp', 'flint'], include_dirs = [SAGE_ROOT + '/local/include/FLINT/'], extra_compile_args = ['-std=c99'], depends = [SAGE_ROOT + "/local/include/FLINT/flint.h"]),
comment:8 Changed 11 years ago by
I thought I had taken care of that. My apologies it will take a few hours until I can take care of them.
Changed 11 years ago by
I missed a number of flint dependencies in the original patch. Apply trac_11377-build_module_listpy.patchafter
comment:9 Changed 11 years ago by
- Description modified (diff)
- Status changed from needs_work to needs_review
It turns out I had missed another instance of flint in sage.set.disjoints.set. So the additional patch takes care of it. It was all done on top of alpha2, hopefully there is nothing wrecking it already in alpha3.
patch to module_list.py