Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#11367 closed enhancement (fixed)

Rounding values, and inconsistencies in graph methods

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.8
Component: graph theory Keywords:
Cc: nthiery Merged in: sage-4.8.alpha0
Authors: Nathann Cohen Reviewers: Leonardo Sampaio
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

This patch rounds values of methods when their result is expected to be integer (dominating set, flows, connectivity, ...)

It also modifies a "weight" parameter which should be replaced by the usual "use_edge_labels" parameter used throughout the file.

Nathann

Attachments (1)

trac_11367.patch​ (18.7 KB) - added by ncohen 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by ncohen

  • Status changed from new to needs_review

Changed 8 years ago by ncohen

comment:2 Changed 8 years ago by lsampaio

  • Reviewers set to Leonardo Sampaio
  • Status changed from needs_review to positive_review

The patch is working and I believe it should be merged to sage.

comment:3 Changed 8 years ago by jdemeyer

  • Authors set to Nathann Cohen
  • Milestone changed from sage-4.7.2 to sage-4.7.3
  • Type changed from defect to enhancement

comment:4 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.3.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:5 Changed 8 years ago by jdemeyer

  • Milestone sage-4.7.3 deleted

Milestone sage-4.7.3 deleted

comment:6 Changed 8 years ago by jdemeyer

  • Merged in changed from sage-4.7.3.alpha0 to sage-4.8.alpha0
  • Milestone set to sage-4.8
Note: See TracTickets for help on using tickets.