Opened 9 years ago

Closed 9 years ago

#11357 closed defect (fixed)

Upgrade GSL to the latest version (1.15), which fixes some GSL bugs and builds on AIX.

Reported by: drkirkby Owned by: drkirkby
Priority: major Milestone: sage-4.7.1
Component: packages: standard Keywords:
Cc: fbissey Merged in: sage-4.7.1.alpha2
Authors: David Kirkby, François Bissey Reviewers: David Kirkby, François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by drkirkby)

Version 1.15 of GSL was released on 5th May this year, so this ticket updates from 1.14 to 1.15.

Apart from fixing some GSL bugs, my own changes to build this on AIX have been accepted upstream, so this package will now build on AIX. This means #10000 can be closed when this is merged.

Dave

New spkg: http://boxen.math.washington.edu/home/kirkby/patches/gsl-1.15.spkg

Apply:

Once merged, #10000 can be closed too.

Attachments (2)

upgrade_GSL_to_version_1.15.patch (1.5 KB) - added by drkirkby 9 years ago.
Just document the change in SPKG.txt - nothing else was done apart from using the latest GSL source.
trac_11357-fix_gsl_doctest.patch (1.2 KB) - added by fbissey 9 years ago.
Fix the doctests broken by gsl-1.15 - those are really sage bugs as well.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by drkirkby

Just document the change in SPKG.txt - nothing else was done apart from using the latest GSL source.

Changed 9 years ago by fbissey

Fix the doctests broken by gsl-1.15 - those are really sage bugs as well.

comment:1 follow-up: Changed 9 years ago by fbissey

  • Authors set to David Kirkby, François Bissey
  • Description modified (diff)
  • Status changed from new to needs_review

In a case of scratch my back I will check your spkg and you can check my patch.

comment:2 in reply to: ↑ 1 Changed 9 years ago by drkirkby

Replying to fbissey:

In a case of scratch my back I will check your spkg and you can check my patch.

I'm just in the process of building sage-4.7.rc4, but have dropped in the new gsl package. I'll then doctest this. The patch looks fine to me, but I'll double check it. It's 2230 here, so I may or may not do this before I go to bed. I don't take too long on this machine (about an 60-90 minutes to build Sage and run all the long doctests), but I'm feeling a bit tired. Will probably hit the bed soon.

Let me know if you think my package is ok. If so, and I'm happy with your patch, I'll mark us both as reviewers and set it to positive review.

Dave

Dave

comment:3 Changed 9 years ago by fbissey

So far it looks good, I installed it on my x86 box and rebuild an earlier sage-4.7, I am not too hot about tests on that machine anymore (minimum 4 hours, long test 6 to 7) but I'll do a full test on OSX 10.5.8 later today.

comment:4 Changed 9 years ago by drkirkby

  • Description modified (diff)
  • Owner changed from tbd to drkirkby
  • Reviewers set to David Kirkby, François Bissey

I'm happy with your doctest patch. I built Sage 4.7.rc4 using gcc 4.6.0 on a Sun Ultra 27 running OpenSolaris 06/2009. The following two tests failed, but passed after the patch was installed.

drkirkby@hawk:~/sage-4.7.rc4$ ./sage -t  -long -force_lib devel/sage/sage/gsl/probability_distribution.pyx
sage -t -long -force_lib "devel/sage/sage/gsl/probability_distribution.pyx"
	 [2.5 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 2.5 seconds
drkirkby@hawk:~/sage-4.7.rc4$ ./sage -t  -long -force_lib devel/sage/sage/gsl/interpolation.pyx
sage -t -long -force_lib "devel/sage/sage/gsl/interpolation.pyx"
	 [2.1 s]
 
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 2.1 seconds

If you are happy with my GSL package, then this can be set to positive review.

Once merged, #10000 can be closed too.

Dave

comment:5 Changed 9 years ago by fbissey

  • Status changed from needs_review to positive_review

It's all satisfactory to me on OS X 10.5.8. Positive review.

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.