Opened 9 years ago
Closed 3 years ago
#11349 closed defect (fixed)
Doctest fix for: Sage can't make sense of a Maxima result
Reported by: | kcrisman | Owned by: | rws |
---|---|---|---|
Priority: | major | Milestone: | sage-8.0 |
Component: | symbolics | Keywords: | erf inverse erfinv inverf |
Cc: | Merged in: | ||
Authors: | Ralf Stephan | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 2901da8 (Commits) | Commit: | 2901da8005a7f2eefdb317fd4bbce66a1e6751e1 |
Dependencies: | #21819 | Stopgaps: |
Description (last modified by )
Mpmath has an inverse erf. Maxima now has an inverse erf. We need it too.
It should be both symbolic and evaluated. !Function_Erf could be used as a model. Make sure to add it to the conversion list in sage.symbolic.pynac! (Which should be elsewhere in any case...)
See this ask.sagemath question for background.
Defect because Sage can't make sense of a Maxima result:
sage: var('z,t') (z, t) sage: PDF = exp(-x^2 /2)/sqrt(2*pi) sage: integralExpr = integrate(PDF,x,z,oo).subs(z==log(t)) sage: y = solve(integralExpr==z,t)[0].rhs().subs(z==1/4) sage: y e^(sqrt(2)*inverse_erf(1/2)) sage: inverse_erf? Object `inverse_erf` not found.
Change History (17)
comment:1 Changed 6 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:2 Changed 6 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:3 Changed 6 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:4 Changed 5 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:5 Changed 5 years ago by
- Description modified (diff)
- Milestone changed from sage-6.4 to sage-6.6
- Owner changed from burcin to rws
- Type changed from enhancement to defect
comment:6 Changed 3 years ago by
- Branch set to u/rws/implement_inverse_erf_function
comment:7 Changed 3 years ago by
- Commit set to fbe5d29fdf04e5c635a7a91c2aa1f8875ac09e57
- Dependencies set to #21819
- Status changed from new to needs_review
comment:9 Changed 3 years ago by
- Commit changed from fbe5d29fdf04e5c635a7a91c2aa1f8875ac09e57 to 142319f41f168932fb1518867782669d0cd6378b
Branch pushed to git repo; I updated commit sha1. New commits:
d227a3f | Merge branch 'develop' into t/11349/implement_inverse_erf_function
|
2fb1d2d | Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation
|
be39e50 | 21819: fixes
|
142319f | Merge branch 'u/rws/rewrite_error_functions_and_documentation' of git://trac.sagemath.org/sage into t/11349/implement_inverse_erf_function
|
comment:10 Changed 3 years ago by
- Milestone changed from sage-6.6 to sage-7.6
- Status changed from needs_work to needs_review
comment:11 Changed 3 years ago by
- Commit changed from 142319f41f168932fb1518867782669d0cd6378b to 70b27524aba47047b95cc04211951fa96bdcdd0b
Branch pushed to git repo; I updated commit sha1. New commits:
70b2752 | Merge branch 'develop' into t/11349/implement_inverse_erf_function
|
comment:12 Changed 3 years ago by
- Branch changed from u/rws/implement_inverse_erf_function to u/rws/11349-1
comment:13 Changed 3 years ago by
- Branch changed from u/rws/11349-1 to u/rws/implement_inverse_erf_function
- Milestone changed from sage-7.6 to sage-8.0
- Summary changed from Implement Inverse Erf function to Doctest fix for: Sage can't make sense of a Maxima result
comment:14 Changed 3 years ago by
Squashed.
comment:15 Changed 3 years ago by
- Branch changed from u/rws/implement_inverse_erf_function to u/rws/11349-1
- Commit changed from 70b27524aba47047b95cc04211951fa96bdcdd0b to 2901da8005a7f2eefdb317fd4bbce66a1e6751e1
comment:16 Changed 3 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:17 Changed 3 years ago by
- Branch changed from u/rws/11349-1 to 2901da8005a7f2eefdb317fd4bbce66a1e6751e1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
21819: erf() reorg
Merge branch 'develop' into t/21819/rewrite_error_functions_and_documentation
21819: address reviewer's comments; maxima erfc bindings
11349: doctest fix for: Sage can't make sense of a Maxima result