Opened 9 years ago
Closed 7 years ago
#11345 closed enhancement (duplicate)
Period method for quadratic irrationals
Reported by: | benjaminfjones | Owned by: | davidloeffler |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | number fields | Keywords: | continued fraction, arithmetic |
Cc: | kcrisman | Merged in: | |
Authors: | Reviewers: | Benjamin Jones, Vincent Delecroix | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #14567 | Stopgaps: |
Description
We propose implementing a period
method for quadratic irrational elements of the field of continued fractions.
See the post at http://ask.sagemath.org/question/545/continued-fraction-expansion-of-quadratic for an algorithm.
Change History (9)
comment:1 Changed 9 years ago by
- Cc kcrisman added
comment:2 follow-up: ↓ 3 Changed 9 years ago by
I intend to provide a patch, I just thought I'd get the ball rolling. Maybe I should have waited to file the ticket, though. I'll be on vacation until June 6.
I'm not familiar with the term "surd", but I guess that means an algebraic number, or maybe just an n-th root?
comment:3 in reply to: ↑ 2 Changed 9 years ago by
Replying to benjaminfjones:
I intend to provide a patch, I just thought I'd get the ball rolling. Maybe I should have waited to file the ticket, though. I'll be on vacation until June 6.
No, always file a ticket - then others know about it, and so forth. Many, many, many tickets are filed that don't have patches for a long time, but do have ideas.
I'm not familiar with the term "surd", but I guess that means an algebraic number, or maybe just an n-th root?
See here, for example. It's an old term for (quadratic) irrationals, more or less. You see it a lot in books written before about 1960, esp. number theory ones.
comment:4 Changed 7 years ago by
Hi,
This is a long standing ticket and I guess nobody is working on it anymore. I will close it as a duplicate as soon as #14567 is finished. Any comment or contribution welcome!
Vincent
comment:5 Changed 7 years ago by
Agreed. Nice work on #14567.
comment:6 Changed 7 years ago by
- Milestone changed from sage-5.10 to sage-pending
- Reviewers set to Benjamin Jones, Vincent Delecrois
- Status changed from new to needs_review
comment:7 Changed 7 years ago by
- Dependencies set to #14567
- Reviewers changed from Benjamin Jones, Vincent Delecrois to Benjamin Jones, Vincent Delecroix
- Status changed from needs_review to positive_review
To release manager: when #14567 is merged, this should become sage-duplicate.
comment:8 Changed 7 years ago by
- Milestone changed from sage-pending to sage-duplicate/invalid/wontfix
comment:9 Changed 7 years ago by
- Resolution set to duplicate
- Status changed from positive_review to closed
Well, an algorithm isn't a patch :) but this is a promising start.
However, one would want to make sure there was a way to check whether this was actually a quadratic surd before using this method. I think that the poster's comment about the Maple documentation for this could provide some helpful thoughts, though I don't think we'd want to slavishly follow the syntax or anything, especially as we have the field of continued fractions to help us out.
One more random thought; is it possible to hack out the code from GAP for this in some way, so as not to reinvent the wheel?