Changes between Version 12 and Version 16 of Ticket #11339


Ignore:
Timestamp:
06/18/11 07:45:30 (10 years ago)
Author:
vbraun
Comment:

In the case at hand we don't really need the Cython class GroebnerStrategy._parent, only the C struct GroebnerStrategy._parent._ring is used in __deallocate__(). I've made a minimal patch that adds a cdef ring *_parent_ring data member to GroebnerStrategy to keep track of the ring only. Because it refers to a C struct, it is safe to access it the Cython destructor. Because parents are immutable we don't have to worry about the ring * pointer becoming invalid.

The patch should fix the crash, but I don't have a Sage-on-Python-2.7 install to test it. Can somebody give it a try?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #11339

    • Property Status changed from positive_review to needs_review
    • Property Authors changed from to Volker Braun, Martin von Gagern
    • Property Keywords sd31 added
  • Ticket #11339 – Description

    v12 v16  
    66
    77Apply:
    8  * [attachment:bug11339a.patch]
     8 * [attachment:trac_11339_illegal_use_of__deallocate__in_libsingular.patch]