Opened 8 years ago

Closed 8 years ago

#11331 closed defect (fixed)

PolyBoRi won't build on OS X 10.4 PPC G4

Reported by: kcrisman Owned by: AlexanderDreyer
Priority: blocker Milestone: sage-4.7
Component: build Keywords:
Cc: jdemeyer, GeorgSWeber, AlexanderDreyer, PolyBoRi Merged in: sage-4.7.rc4
Authors: Alexander Dreyer Reviewers: Georg S. Weber, Karl-Dieter Crisman
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

With both XCode 2.4.1 and 2.5, builds consistently fail at PolyBoRi on Mac OS X 10.4 on PowerPC G4 chips.

No other platforms seem to be affected, including G5 chips and 10.5 on a G4.

Depending on the machine and the version, the error seems to hit at different places, but in the end it's always failing. See for example this sage-release thread.

It is a bug in gcc.

This is with sage-4.7.rc0 through rc2. alpha5 is unaffected, which is truly bizarre. Since Singular's latest (rc2, p9) builds fine on these machines, it might be the bzip2 package upgrade that is the issue, unlikely though this may seem.

E.g.,

Dasher-03:~/Desktop/sage-4.7.rc1 student$ make 
cd spkg && "../spkg/pipestatus" "./install all 2>&1" "tee -a ../ 
install.log" 
*** ALL ENVIRONMENT VARIABLES BEFORE BUILD: *** 
SAGENB=sagenb-0.8.14 
GD=gd-2.0.35.p5 
CONWAY=conway_polynomials-0.2 
CLIQUER=cliquer-1.2.p8 
READLINE=readline-6.1 
JINJA2=jinja2-2.5.5 
SAGE_LOGS=/Users/student/Desktop/sage-4.7.rc1/spkg/logs 
PEXPECT=pexpect-2.0.p4 
F2C=f2c-20070816.p2 
TERM_PROGRAM=Apple_Terminal 
MATPLOTLIB=matplotlib-1.0.1 
G2RED=genus2reduction-0.3.p8 
LIBM4RI=libm4ri-20100701.p1 
SAGE_BZIP2=bzip2-1.0.5 
TERM=xterm-color 
SHELL=/bin/sh 
CYTHON=cython-0.14.1.p1 
MAKEFLAGS= 
SQLALCHEMY=sqlalchemy-0.5.8 
DOCUTILS=docutils-0.5.p0 
ZNPOLY=zn_poly-0.9.p5 
SYMMETRICA=symmetrica-2.0.p5 
GIVARO=givaro-3.2.13rc2.p2 
TERM_PROGRAM_VERSION=133-1 
SAGETEX=sagetex-2.2.5 
MPFR=mpfr-2.4.2 
SYMPY=sympy-0.6.4.p0 
POLYTOPES_DB=polytopes_db-20100210 
OLDPWD=/Users/student/Desktop/sage-4.7.rc1 
EXAMPLES=examples-4.7.rc1 
ATLAS=atlas-3.8.3.p16 
PREREQ=prereq-0.8 
DIR=dir-0.1 
TACHYON=tachyon-0.98.9.p3 
MPFI=mpfi-1.3.4-cvs20071125.p8 
MERCURIAL=mercurial-1.6.4.p0 
CDDLIB=cddlib-094f.p8 
ECLIB=eclib-20100711 
USER=student 
R=r-2.10.1.p4 
SPHINX=sphinx-1.0.4.p6 
LIBGCRYPT=libgcrypt-1.4.4.p3 
CVXOPT=cvxopt-1.1.3 
BOEHM_GC=boehm_gc-7.1.p6 
TERMCAP=termcap-1.3.1.p1 
MPIR=mpir-1.2.2.p2 
ZODB=zodb3-3.7.0.p4 
GRAPHS=graphs-20070722.p1 
ICONV=iconv-1.13.1.p3 
__CF_USER_TEXT_ENCODING=0x1F7:0:0 
ECL=ecl-11.1.1.p0 
CEPHES=cephes-2.8 
SAGE_LOCAL=/Users/student/Desktop/sage-4.7.rc1/local 
MAKELEVEL=1 
SAGE_SCRIPTS=sage_scripts-4.7.rc1 
ECM=ecm-6.2.1.p2 
TWISTED=twisted-9.0.p2 
RUBIKS=rubiks-20070912.p15 
FREETYPE=freetype-2.3.5.p3 
MFLAGS= 
PYGMENTS=pygments-1.3.1.p0 
GAP=gap-4.4.12.p5 
PATH=/Users/student/Desktop/sage-4.7.rc1:/Users/student/Desktop/ 
sage-4.7.rc1/local/bin:/bin:/sbin:/usr/bin:/usr/sbin 
IML=iml-1.0.1.p13 
LAPACK=lapack-20071123.p2 
EXTCODE=extcode-4.7.rc1 
BLAS=blas-20070724 
ZLIB=zlib-1.2.5 
SINGULAR=singular-3-1-1-4.p8 
GNUTLS=gnutls-2.2.1.p5 
POLYBORI=polybori-0.7.0.p2 
LIBGPG_ERROR=libgpg_error-1.6.p3 
PWD=/Users/student/Desktop/sage-4.7.rc1/spkg 
LCALC=lcalc-20100428-1.23.p6 
SCONS=scons-1.2.0 
LINBOX=linbox-1.1.6.p3 
OPENCDK=opencdk-0.6.6.p5 
FLINTQS=flintqs-20070817.p5 
GDMODULE=gdmodule-0.56.p7 
SCIPY=scipy-0.9 
SAGE_ROOT_REPO=sage_root-4.7.rc1 
GFAN=gfan-0.4plus.p1 
SAGE_ROOT=/Users/student/Desktop/sage-4.7.rc1 
SAGE=sage-4.7.rc1 
RATPOINTS=ratpoints-2.1.3.p1 
NUMPY=numpy-1.5.1 
PARI=pari-2.4.3.alpha.p5 
PATCH=patch-2.5.9.p0 
GLPK=glpk-4.44 
PPL=ppl-0.11.2 
PALP=palp-1.1.p3 
SHLVL=4 
HOME=/Users/student 
PYCRYPTO=pycrypto-2.1.0 
GSL=gsl-1.14 
PYTHON_GNUTLS=python_gnutls-1.1.4.p7 
IPYTHON=ipython-0.9.1.p0 
FLINT=flint-1.5.0.p5 
PYTHONPATH=/Users/student/Desktop/sage-4.7.rc1/local 
LOGNAME=student 
SQLITE=sqlite-3.7.5 
MPMATH=mpmath-0.17 
NTL=ntl-5.4.2.p12 
FORTRAN=fortran-20100629 
PIL=pil-1.1.6.p4 
SYMPOW=sympow-1.018.1.p8 
PYNAC=pynac-0.2.1 
MAXIMA=maxima-5.23.2 
FPLLL=libfplll-3.0.12.p1 
SETUPTOOLS=setuptools-0.6c9.p0 
MOIN=moin-1.9.1.p1 
ELLIPTIC_CURVES=elliptic_curves-0.1 
BOOST_CROPPED=boost-cropped-1.34.1 
SECURITYSESSIONID=69af20 
PYTHON=python-2.6.4.p10 
NETWORKX=networkx-1.2.p1 
LIBPNG=libpng-1.2.35.p3 
_=/usr/bin/env 
*********************************************** 
/Users/student/Desktop/sage-4.7.rc1/spkg/pipestatus "sage-spkg $ 
{SAGE_SPKG_OPTS} polybori-0.7.0.p2 2>&1" "tee -a /Users/student/ 
Desktop/sage-4.7.rc1/spkg/logs/polybori-0.7.0.p2.log" 
Warning: Attempted to overwrite SAGE_ROOT environment variable 
polybori-0.7.0.p2 
Machine: 
Darwin Dasher-03.local 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 
18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh 
powerpc 
Deleting directories from past builds of previous/current versions of 
polybori-0.7.0.p2 
Extracting package /Users/student/Desktop/sage-4.7.rc1/spkg/standard/ 
polybori-0.7.0.p2.spkg ... 
-rw-r--r--   1 student  student  1885217 Mar 30 18:44 /Users/student/ 
Desktop/sage-4.7.rc1/spkg/standard/polybori-0.7.0.p2.spkg 
Finished extraction 
**************************************************** 
Host system 
uname -a: 
Darwin Dasher-03.local 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 
18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh 
powerpc 
**************************************************** 
**************************************************** 
CC Version 
gcc -v 
Using built-in specs. 
Target: powerpc-apple-darwin8 
Configured with: /private/var/tmp/gcc/gcc-5367.obj~1/src/configure -- 
disable-checking -enable-werror --prefix=/usr --mandir=/share/man -- 
enable-languages=c,objc,c++,obj-c++ --program-transform-name=/^[cg] 
[^.-]*$/s/$/-4.0/ --with-gxx-include-dir=/include/c++/4.0.0 --with- 
slibdir=/usr/lib --build=powerpc-apple-darwin8 --host=powerpc-apple- 
darwin8 --target=powerpc-apple-darwin8 
Thread model: posix 
gcc version 4.0.1 (Apple Computer, Inc. build 5367) 
**************************************************** 
Starting build... 
Removing old PolyBoRi install... 
Done removing old PolyBoRi install. 
Running build_polybori... 
scons: Reading SConscript files ... 
darwin linker detected! 
Platform:  darwin 
Checking for C header file gd.h... yes 
Checking for C library gd... yes 
Checking for C++ header file ext/hash_map... yes 
Warning: No LaTeX to html converter found, Tutorial will not be 
installed 
Checking for C library m4ri... yes 
Checking for C header file gd.h... yes 
Checking for C library gd... yes 
no python extension 
scons: done reading SConscript files. 
scons: Building targets ... 
g++ -o polybori/src/BoolePolyRing.o -c -O3 -Wno-long-long -Wreturn- 
type -g -fPIC -ftemplate-depth-100 -O3 -Wno-long-long -Wreturn-type -g 
-fPIC -DNDEBUG -DHAVE_GD -DHAVE_HASH_MAP -DPACKED -DHAVE_M4RI - 
DHAVE_GD -DHAVE_IEEE_754 -I/Users/student/Desktop/sage-4.7.rc1/local/ 
include -I/Users/student/Desktop/sage-4.7.rc1/local/include/python2.6 - 
Ipolybori/include -ICudd/obj -ICudd/util -ICudd/cudd -ICudd/mtr -ICudd/ 
st -ICudd/epd polybori/src/BoolePolyRing.cc 
[address=019fffff pc=003f11d8] 
In file included from polybori/include/CCheckedIdx.h:17, 
                 from polybori/include/BoolePolyRing.h:23, 
                 from polybori/include/BooleEnv.h:20, 
                 from polybori/include/CTermIter.h:28, 
                 from polybori/include/CDelayedTermIter.h:20, 
                 from polybori/include/COrderedIter.h:23, 
                 from polybori/include/COrderingBase.h:22, 
                 from polybori/include/COrderingFacade.h:23, 
                 from polybori/include/DegRevLexAscOrder.h:20, 
                 from polybori/include/pbori_order.h:27, 
                 from polybori/src/BoolePolyRing.cc:26: 
polybori/include/pbori_defs.h:1: internal compiler error: Segmentation 
Fault 
Please submit a full bug report, 
with preprocessed source if appropriate. 
See <URL:http://developer.apple.com/bugreporter> for instructions. 
scons: *** [polybori/src/BoolePolyRing.o] Error 1 
scons: building terminated because of errors. 
Error building PolyBoRi. 
real    0m37.750s 
user    0m14.012s 
sys     0m6.039s 
sage: An error occurred while installing polybori-0.7.0.p2 
Please email sage-devel http://groups.google.com/group/sage-devel 
explaining the problem and send the relevant part of 
of /Users/student/Desktop/sage-4.7.rc1/install.log.  Describe your 
computer, operating system, etc. 
If you want to try to fix the problem yourself, *don't* just cd to 
/Users/student/Desktop/sage-4.7.rc1/spkg/build/polybori-0.7.0.p2 and 
type 'make check' or whatever is appropriate. 
Instead, the following commands setup all environment variables 
correctly and load a subshell for you to debug the error: 
(cd '/Users/student/Desktop/sage-4.7.rc1/spkg/build/polybori-0.7.0.p2' 
&& '/Users/student/Desktop/sage-4.7.rc1/sage' -sh) 
When you are done debugging, you can type "exit" to leave the 
subshell. 
make[1]: *** [installed/polybori-0.7.0.p2] Error 1 
real    0m48.491s 
user    0m18.221s 
sys     0m8.112s 
Error building Sage. 
make: *** [build] Error 1

New spkg: http://boxen.math.washington.edu/home/dreyer/spkg/polybori-0.7.0.p3.spkg

Attachments (1)

polybori-0.7.0.p3-vs-p2.patch (8.8 KB) - added by AlexanderDreyer 8 years ago.
spkg-patch (just to simplify reviewing)

Download all attachments as: .zip

Change History (28)

comment:1 Changed 8 years ago by AlexanderDreyer

  • Cc AlexanderDreyer PolyBoRi added
  • Owner changed from GeorgSWeber to AlexanderDreyer

Can you try the package for PolyBoRi? 0.7.1 from #11261? Unfortunately, I do not have access to that platform.

comment:2 Changed 8 years ago by kcrisman

Nice idea! But the error is the same.

I'm not even sure this is a PolyBoRi problem per se. The activity monitor shows that there is still a fair amount of RAM left during this process, and while the CPU is being intensely used, the highest level of use is the unzipping, and otherwise it's not really different from other things.

My very rough guess at this point is that we may want to try setting the optimization level down a bit here, but I don't know how to do that.

comment:3 follow-up: Changed 8 years ago by kcrisman

Another thing is that if you can give me a VERY easy way to try to build this from scratch, without Sage (though perhaps using Sage Python etc.) on this machine, I could see if that works.

comment:4 in reply to: ↑ 3 Changed 8 years ago by AlexanderDreyer

Replying to kcrisman:

Another thing is that if you can give me a VERY easy way to try to build this from scratch, without Sage (though perhaps using Sage Python etc.) on this machine, I could see if that works.

First of all enter the Sage environment (This does not start Sage, just a shell with all environment variables and paths defined): ./sage -sh Then extract the package tar -xvjf polybori-0.7.0.p6.spkg Enter the directory the newly generated directory and start the package building manually cd polybori-0.7.0.p6; ./spkg-install Alternatively, use PolyBoRi's build system directly: cd polybori-0.7.0.p6/src/polybori-0.7; scons . (The . is mandatory to build everything.)

Maybe the problem is causes by the nested header inclusions. Perhaps the compiler is running out of stack.

You may try the following out: In the beginning of the headers in the polybori-0.7.0.p6/src/polybori-0.7/*/include directories you'll find something like the following:

#ifndef FileName_h_
#define FileName_h_

Sometimes there are #include <header> statement above this lines. It could save stack, if you move the #includes below the #defines.

Perhaps you can just try out those headers which are mentioned in the error message above

Best regards,

Alexander

comment:5 Changed 8 years ago by kcrisman

Since I am not sure which of those header files are the 'right' ones, I am reluctant to take a lot of time with that yet. Using the spkg-install does same thing. Interestingly, using PolyBoRi?'s system does not start building with BoolePolyRing.cc, as it does with Sage, but rather !cuddAPI.c. Is that significant?

But yes, on these older machines, perhaps the specific combination of old gcc, old processor, makes for the problem. Certainly a segmentation fault sounds like a compiler running out of something; I assume this is where the concept of stack overflow comes from (I just know the website...).

comment:6 Changed 8 years ago by kcrisman

Okay, tried it from the build system in PolyBoRi itself. Went very well for quite some time, but then failed on exactly the same file as before (BoolePolyRing.cc), though of course it had done all kinds of other stuff first. Interestingly, it created BoolePolyRing.os fine, it was in making BoolePolyRing.o that the troubles came (as with the Sage build).

I will try to check what my other computer with this setup failed at; I don't think it was the same file.

comment:7 Changed 8 years ago by kcrisman

Here is where a nearly identical machine - also XCode 2.5, but 1.25 !GHz instead of 770 !MHz, and 1 GB memory instead of 512 MB memory - fails - rather further into the compilation.

g++ -o groebner/src/groebner_alg.os -c -O3 -Wno-long-long -Wreturn-type -g -fPIC -ftemplate-depth-100 -O3 -Wno-long-long -Wreturn-type -g -fPIC -fPIC -fvisibility=hidden -DNDEBUG -DHAVE_GD -DHAVE_HASH_MAP -DPACKED -DHAVE_M4RI -DHAVE_GD -DHAVE_IEEE_754 -I/Users/crisman/sage-4.7.rc2/local/include -I/Users/crisman/sage-4.7.rc2/local/include/python2.6 -Ipolybori/include -ICudd/obj -ICudd/util -ICudd/cudd -ICudd/mtr -ICudd/st -ICudd/epd groebner/src/groebner_alg.cc
[address=019fffff pc=003f17d8]
In file included from polybori/include/pbori_traits.h:20,
                 from polybori/include/pbori_func.h:19,
                 from polybori/include/BooleSet.h:22,
                 from polybori/include/CTermStack.h:39,
                 from polybori/include/CStackSelector.h:23,
                 from polybori/include/COrderedIter.h:27,
                 from polybori/include/COrderingFacade.h:25,
                 from polybori/include/LexOrder.h:20,
                 from polybori/include/pbori_order.h:25,
                 from polybori/include/polybori.h:33,
                 from groebner/src/groebner_alg.h:12,
                 from groebner/src/groebner_alg.cc:10:
polybori/include/pbori_defs.h:1: internal compiler error: Segmentation Fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://developer.apple.com/bugreporter> for instructions.
scons: *** [groebner/src/groebner_alg.os] Error 1
scons: building terminated because of errors.
Error building PolyBoRi.

real    11m53.429s
user    9m43.204s
sys     1m24.262s

What is the difference between the .o and .os files, anyway? Are both needed for Sage?

comment:8 follow-up: Changed 8 years ago by AlexanderDreyer

As ususal: the .os are prepared for shared libs (compiled with .-fPIC).

Did you try out the changes in the src directory I suggested above?

comment:9 in reply to: ↑ 8 Changed 8 years ago by kcrisman

Replying to AlexanderDreyer:

As ususal: the .os are prepared for shared libs (compiled with .-fPIC).

Did you try out the changes in the src directory I suggested above?

Well, given that I don't know what .os files are, you might imagine it would take me quite a while to try something like that :)

I have tried moving the #include statements below the #ifndef in two files that seemed likely - COrderedIter.h and pbori_order.h. They are the only two which show up in both traces. I did this 100% by hand, and I hope that running spkg-install from ./sage -sh in that directory will be enough to use the modified files. It already made it past groebner_alg.os, which is a good sign... but this has been bad enough that I will wait to see.

While I'm waiting, I'll ask the dumb question: are all these include statements supposed to be inside the #ifndef usually? If so, why aren't they? If not, why would this make a difference?

Done installing PolyBoRi.
SAGE_ROOT=/Users/crisman/sage-4.7.rc2
(sage subshell) new-host:polybori-0.7.0.p2 crisman$ 

Well, that seemed to work! Again, I only did it with these two files.

Now I am going to revert the change to COrderedIter.h and keep only the one to pbori_order.h, and try it again.

comment:10 Changed 8 years ago by kcrisman

Another update - the change to pbori_order.h did not fix the problem on the slower machine (the one that failed at g++ -o polybori/src/BoolePolyRing.o) but adding the change to COrderedIter.h did allow it to proceed past that very first file (hasn't finished yet).

And the attempt with only pbori_order.h changed on the newer machine led to the exact same failure as before. So it seems that this is the problem.

So why is it the problem? I do not want to have to chase this all down again with every PolyBoRi upgrade, as you can imagine. If there is a good reference for why this would make the difference online, that would be great.

And if doing this on all files would help solve it in the future anyway, that would be fine too :)

comment:11 follow-up: Changed 8 years ago by kcrisman

Yup, changing COrderedIter.h to move the #include statements did the trick on both machines.

If you include something about this - and explanation!!! since this all seems quite magical to me - on #11261, then that would close this ticket as well. Or a separate spkg update could be made for this. Naturally, I would be willing to test them.

comment:12 in reply to: ↑ 11 Changed 8 years ago by AlexanderDreyer

Replying to kcrisman:

Yup, changing COrderedIter.h to move the #include statements did the trick on both machines. If you include something about this - and explanation!!! since this all seems quite magical to me - on #11261, then that would close this ticket as well. Or a separate spkg update could be made for this.

I will update and rebundle #11261 later (I need to rebase it on the new 0.7.0 spkg, when accepted). The explanation is as follows: Without the patch the compiler hast to open and stack a lot of headers which are immediately closed, because the current compilation procedure had already entered them. But anyway: they were stacked. With the patch these files are never opened. Since this never caused problems before, I did not take care on the order of #include and {{#ifndef}}/#define statements. (This will be fixed upstream also soon.)

Naturally, I would be willing to test them.

Nice, please have a look here:

http://boxen.math.washington.edu/home/dreyer/spkg/polybori-0.7.0.p3.spkg

Changed 8 years ago by AlexanderDreyer

spkg-patch (just to simplify reviewing)

comment:13 Changed 8 years ago by AlexanderDreyer

  • Status changed from new to needs_review

comment:14 Changed 8 years ago by AlexanderDreyer

  • Authors set to Alexander Dreyer
  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.

comment:15 Changed 8 years ago by GeorgSWeber

  • Reviewers set to Georg S. Weber
  • Status changed from needs_review to positive_review

Hi,

what a nice "ready-to-go" new spkg and "p3-vs-p2" patch, presented on "a silver tablet" --- I just couldn't resist!

Both my MacIntel? and my MacPPC systems use OS X 10.4.11 with XCode 2.5 (the MacIntel? has a Core2Duo CPU with 2 GHz and 2 GB RAM, the MacPPC has an older G4 CPU with 550 MHz and 768 MB RAM). These are the findings from my side (all one-time tries only):

  • On my MacIntel? with Sage-4.7.alpha4 (and polybori-0.7.0.p2), building from scratch went fine, but with Sage-4.7.rc2 (and the very same polybori-0.7.0.p2), building from scratch broke with the described internal compiler error.
  • On my MacPPC with Sage-4.7.rc2 (and still polybori-0.7.0.p2), building from scratch went fine(!!).

So the issue of this ticket firstly does not seem to hit in 100% of the cases, and secondly seems to affect both the MacIntel? and MacPPC platforms ...

I updated on both systems the Sage-4.7.rc2 install with the new polybori-0.7.0.p3 spkg of this ticket, and on both systems they did build fine. On the MacIntel?, "make testlong" finished in the meantime, and passed fine (except for the known old "maxima.py" issue, which is unrelated).

The SPKG.txt is updated correctly, even the mercurial repository looks good, excellent! The only downside might be that the problem still lurks, since only more testing really could give confidence. But the best way to achieve the latter is to drop this spkg in the mainline code base, which is justified, because regressions are hardly to be awaited from looking at the tiny (and very local) changes.

All in all: positive review.

comment:16 follow-up: Changed 8 years ago by kcrisman

  • Reviewers changed from Georg S. Weber to Georg S. Weber, Karl-Dieter Crisman

Wow, great review, Georg. How bizarre about the Intel/PPC thing. But is your PPC a G5 or G4? We only saw it on G4 machines until this report.

David Kirkby would surely warn us about more compiler madness waiting in the wings if we don't fix the headers, but I know nothing of such things, so this all looks great. I also just independently checked this worked by dropping in this spkg in a freshly untarred rc2 on one of the failing machines, so considering it worked (though not with from scratch) on the only other machine I saw it on, this should be very positive review indeed. I'm adding myself in to the reviewers based on the previous work, if that's okay.

comment:17 in reply to: ↑ 16 Changed 8 years ago by GeorgSWeber

Replying to kcrisman:

But is your PPC a G5 or G4?

It's a 550 MHz G4 PowerPC, the "older one" of the G4's used ("7400" for e.g. TenFourFox?)

I'm adding myself in to the reviewers based on the previous work, if that's okay.

Sure! Having slept over it, I myself felt that I should not have put only my name in that reviewer field, but yours, too. But you were even faster ...

comment:18 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:19 follow-up: Changed 8 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from positive_review to needs_work

AlexanderDryer?: could you please upload the spkg without the added hg tag? My merge script gets confused with the already-added tag.

comment:20 in reply to: ↑ 19 Changed 8 years ago by AlexanderDreyer

  • Status changed from needs_work to needs_review

Replying to jdemeyer:

AlexanderDryer?: could you please upload the spkg without the added hg tag? My merge script gets confused with the already-added tag.

No problem! The new pkg is at the same location: http://boxen.math.washington.edu/home/dreyer/spkg/polybori-0.7.0.p3.spkg

comment:21 follow-up: Changed 8 years ago by GeorgSWeber

  • Status changed from needs_review to positive_review

Hmm, the only difference I can see is that "hg tags" outputs one line less than before (the line with "polybori-0.7.0.p3" is now missing), i.e. the hidden file ".hgtags" has one line less. I didn't know that was important, sorry. But I guess this is what was meant and needed, so positive review renewed.

comment:22 in reply to: ↑ 21 Changed 8 years ago by jdemeyer

Replying to GeorgSWeber:

Hmm, the only difference I can see is that "hg tags" outputs one line less than before (the line with "polybori-0.7.0.p3" is now missing), i.e. the hidden file ".hgtags" has one line less. I didn't know that was important, sorry.

No need to apologize. I am rewriting the spkg handling of my merger script. One change is that it now automatically adds a hg tag, and an already-existing tag will confuse the scripts. Anyway, thanks for the review.

comment:23 Changed 8 years ago by kcrisman

  • Priority changed from major to blocker

comment:24 follow-up: Changed 8 years ago by kcrisman

  • Milestone changed from sage-4.7.1 to sage-4.7

comment:25 in reply to: ↑ 24 ; follow-up: Changed 8 years ago by jdemeyer

Replying to kcrisman: Why changing the milestone so late? I already assumed it was going into the sage-4.7.1 cycle.

comment:26 in reply to: ↑ 25 Changed 8 years ago by kcrisman

Why changing the milestone so late? I already assumed it was going into the sage-4.7.1 cycle.

I think this was probably opened after the default milestone was 4.7.1; similarly with the priority. I never realized it wouldn't make it in. But this does prevent building of Sage, so I guess I kind of assumed it should be in an 'official' release. Especially if we want to produce binaries for 4.7, since several of the machines people use to do this would be affected.

comment:27 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.rc4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.