Opened 10 years ago

Closed 9 years ago

#11326 closed enhancement (duplicate)

make ATLAS respect CC environment variable

Reported by: mariah Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #10226 Stopgaps:

Status badges

Description (last modified by jdemeyer)

ATLAS does not respect the CC environment variable.

Fix with new build system (#10226): http://www.stp.dias.ie/~vbraun/Sage/spkg/atlas-3.8.3.p18.spkg

See Ticket #2999

Attachments (1)

atlas-3.8.3.p16-p17.diff (9.2 KB) - added by mariah 10 years ago.
Diff for the atlas spkg, for reviewing only.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by mariah

  • Description modified (diff)
  • Status changed from new to needs_review

Changed 10 years ago by mariah

Diff for the atlas spkg, for reviewing only.

comment:2 Changed 10 years ago by vbraun

  • Status changed from needs_review to needs_info

Can we implement that on top of #10226? I can make the necessary changes.

Also, it seems like we could avoid modifying the upstream configure script if we just pass --cc=$CC to the configure script. Is there a reason why you didn't follow this less invasive route?

comment:3 Changed 10 years ago by vbraun

I've made a new spkg

http://www.stp.dias.ie/~vbraun/Sage/spkg/atlas-3.8.3.p18.spkg

that should respect $CC. It passes --cc=$CC -C xc $CC -C gc $CC -C ic $CC -C dm $CC -C sm $SS -C dk $CC -C sk $CC to the ATLAS configure script and afterwards fixes up GOODGCC in Make.inc. Note that ATLAS sets GOODGCC = gcc $CC if $CC does not start with gcc.

I'm currently compiling it, but since Make.inc is generated correctly I'm fairly positive that this should work.

comment:4 Changed 10 years ago by vbraun

This fails during linking because GOODGCC needs to include -Fpic on many platforms.

comment:5 Changed 10 years ago by vbraun

  • Description modified (diff)
  • Status changed from needs_info to needs_review

The new version works now. To test it I created a symlink /bin/false -> gcc and set $CC to the correct gcc, and it compiled fine.

http://www.stp.dias.ie/~vbraun/Sage/spkg/atlas-3.8.3.p18.spkg

comment:6 Changed 10 years ago by mariah

  • Authors changed from Mariah Lenox to Volker Braun
  • Description modified (diff)
  • Reviewers set to Mariah Lenox
  • Status changed from needs_review to positive_review

atlas-3.8.3.p18.spkg successfully builds using $CC. Positive review.

comment:7 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.7.1 to sage-feature

Postponing this because of #10226.

comment:8 Changed 10 years ago by jdemeyer

  • Dependencies set to #10226
  • Description modified (diff)

comment:9 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-feature to sage-wait

comment:10 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-pending to sage-4.7.2
  • Status changed from positive_review to needs_work
  • Work issues set to Rebase to #10226

This needs to be rebased to the ATLAS spkg from #10226.

comment:11 Changed 9 years ago by vbraun

  • Milestone changed from sage-5.0 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to positive_review

This has been merged into #10226 a long time ago, but apparently we forgot to close this ticket.

comment:12 Changed 9 years ago by jdemeyer

  • Authors Volker Braun deleted
  • Resolution set to duplicate
  • Reviewers changed from Mariah Lenox to Volker Braun
  • Status changed from positive_review to closed
  • Work issues Rebase to #10226 deleted
Note: See TracTickets for help on using tickets.