Opened 9 years ago

Closed 9 years ago

#11317 closed defect (fixed)

update pynac to 0.2.2

Reported by: burcin Owned by: burcin
Priority: major Milestone: sage-4.7.1
Component: symbolics Keywords:
Cc: jpflori, vbraun, kcrisman Merged in: sage-4.7.1.alpha1
Authors: Richard Kreckel, Vladimir V. Kisil, Jan Rheinländer, Alexei Sheplyakov, Burcin Erocal Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Here is the long awaited pynac update. It includes patches from upstream (ginac) which fix Sage bugs and should be easy to review.

http://sage.math.washington.edu/home/burcin/pynac/pynac-0.2.2.spkg

This package fixes #9891, #9947 and #8943. Attached patch also adds some more doctests to the Sage library.

I hope this can get reviewed and merged soon. There will be an new release with more substantial changes like #9880.

Attachments (1)

trac_11317-conjugate_tests.patch (1.2 KB) - added by burcin 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by burcin

comment:1 Changed 9 years ago by burcin

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman

This is fine too. Notice that there is a typo in the Ginac upstream.

static ex tanh_conjugate(const ex & x)
{
	// conjugate(tan(x))==tan(conjugate(x))
	return tanh(x.conjugate());
}

The method is correct, but the doc says tan, not tanh.


As for the other things, they are nearly all compiler improvements. I'll just check these work on sage.math, but otherwise looks good to go.

comment:3 Changed 9 years ago by kcrisman

  • Status changed from needs_review to positive_review

Good to go. Thank you so much for keeping up with this, Burcin!

comment:4 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.