Opened 11 years ago
Closed 11 years ago
#11317 closed defect (fixed)
update pynac to 0.2.2
Reported by: | burcin | Owned by: | burcin |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7.1 |
Component: | symbolics | Keywords: | |
Cc: | jpflori, vbraun, kcrisman | Merged in: | sage-4.7.1.alpha1 |
Authors: | Richard Kreckel, Vladimir V. Kisil, Jan Rheinländer, Alexei Sheplyakov, Burcin Erocal | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Here is the long awaited pynac update. It includes patches from upstream (ginac) which fix Sage bugs and should be easy to review.
http://sage.math.washington.edu/home/burcin/pynac/pynac-0.2.2.spkg
This package fixes #9891, #9947 and #8943. Attached patch also adds some more doctests to the Sage library.
I hope this can get reviewed and merged soon. There will be an new release with more substantial changes like #9880.
Attachments (1)
Change History (5)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Reviewers set to Karl-Dieter Crisman
comment:3 Changed 11 years ago by
- Status changed from needs_review to positive_review
Good to go. Thank you so much for keeping up with this, Burcin!
comment:4 Changed 11 years ago by
- Merged in set to sage-4.7.1.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
This is fine too. Notice that there is a typo in the Ginac upstream.
The method is correct, but the doc says
tan
, nottanh
.As for the other things, they are nearly all compiler improvements. I'll just check these work on sage.math, but otherwise looks good to go.