Opened 9 years ago

Closed 8 years ago

#11308 closed defect (fixed)

typos in sage.structure.list_clone documentation

Reported by: hivert Owned by: hivert
Priority: trivial Milestone: sage-4.7.1
Component: documentation Keywords: doc clone, days30
Cc: nthiery Merged in: sage-4.7.1.rc0
Authors: Florent Hivert Reviewers: Mariah Lenox, Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Attachments (2)

trac_11308-clone_doc_fix-fh.patch (7.6 KB) - added by nthiery 9 years ago.
trac_11308-clone_doc_fix-fh.2.patch (7.6 KB) - added by hivert 8 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 9 years ago by hivert

  • Authors set to Florent Hivert
  • Owner changed from mvngu to hivert

I got a patch on sage-combinat but more rereading is needed.

comment:2 Changed 9 years ago by saliola

  • Keywords days30 added

comment:3 Changed 9 years ago by hivert

  • Status changed from new to needs_review

comment:4 follow-up: Changed 9 years ago by mariah

  • Status changed from needs_review to needs_work

May I suggest instead of

190	    Finally, if the class implement the ``_hash_`` method then 
191	    :class:`ClonableElement` ensure that hash value is only computed on 
192	    immutable object. It furthermore cache it so that it is only computed 
193	    once. 

use

190	    Finally, if the class implements the ``_hash_`` method then 
191	    :class:`ClonableElement` ensures that hash value is only computed on an
192	    immutable object. It furthermore caches it so that it is only computed 
193	    once. 

Suggested changes:

line 190: implements

line 191: ensures and on an

line 192: caches

comment:5 in reply to: ↑ 4 Changed 9 years ago by nthiery

Replying to mariah:

Suggested changes:

line 190: implements

line 191: ensures and on an

line 192: caches

I am on it.

Changed 9 years ago by nthiery

comment:6 Changed 9 years ago by nthiery

  • Status changed from needs_work to needs_review

Done. Thanks for the report! Btw, I fixed a missing s on another implements above.

comment:7 follow-up: Changed 9 years ago by nthiery

  • Reviewers set to Mariah Lenox, Nicolas M. Thiéry

Btw: Florent: I was sure I had written a reviewer's patch on that one, but don't find a trace of it. Did I dream, or did you already merge it?

Mariah, please check my change! Otherwise, for me, it's good to go.

comment:8 follow-up: Changed 9 years ago by mariah

  • Status changed from needs_review to needs_work

Nicolas, we both missed

line 191: :class:ClonableElement ensures that the hash value can only be

line 192: computed on an immutable object. It furthermore caches it so that

Apologies for being picky!

comment:9 in reply to: ↑ 7 Changed 9 years ago by hivert

Replying to nthiery:

Btw: Florent: I was sure I had written a reviewer's patch on that one, but don't find a trace of it. Did I dream, or did you already merge it?

As I remember we looked on it side by side looking on my computer, but I don't remember any patch. Also there isn't any trace of it in the log.

By the way, thanks for the review.

Also please make sure not to break trac_11407-list_clone_improve-fh.patch in the queue. If reject happen, feel free to refresh the patch.

Changed 8 years ago by hivert

comment:10 in reply to: ↑ 8 Changed 8 years ago by hivert

  • Description modified (diff)
  • Status changed from needs_work to needs_review

Replying to mariah:

Nicolas, we both missed

line 191: :class:ClonableElement ensures that the hash value can only be

line 192: computed on an immutable object. It furthermore caches it so that

Apologies for being picky!

Done ! Thanks for your careful rereading.

comment:11 follow-up: Changed 8 years ago by nthiery

  • Status changed from needs_review to positive_review

comment:12 in reply to: ↑ 11 Changed 8 years ago by hivert

Replying to nthiery:

Thanks !

Florent

comment:13 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.1.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.