Opened 6 years ago

Closed 6 years ago

#11301 closed defect (fixed)

empty partition causes error for up_list

Reported by: saliola Owned by: sage-combinat
Priority: major Milestone: sage-4.7.1
Component: combinatorics Keywords: combinat, partitions, days30
Cc: sage-combinat Merged in: sage-4.7.1.alpha1
Authors: Jason Bandlow Reviewers: Franco Saliola
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11300 Stopgaps:

Description (last modified by jbandlow)

sage: p = Partition([])
sage: p.up_list()
Traceback ...
...
IndexError: list index out of range

Attachments (1)

trac_11301-uplist_fails_on_empty_partition-jb.patch (1.5 KB) - added by jbandlow 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by jbandlow

  • Authors set to Jason Bandlow
  • Cc jbandlow removed
  • Dependencies set to #11300
  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by jbandlow

Notice the dependency on 11300.

comment:3 follow-up: Changed 6 years ago by saliola

  • Reviewers set to Franco Saliola
  • Status changed from needs_review to positive_review

comment:4 in reply to: ↑ 3 ; follow-up: Changed 6 years ago by hivert

Replying to saliola:

Shouldn't we rename up_list to something more meaningful ? What about young_lattice_successors ?

Florent

comment:5 in reply to: ↑ 4 Changed 6 years ago by nthiery

Replying to hivert:

Replying to saliola:

Shouldn't we rename up_list to something more meaningful ? What about young_lattice_successors ?

Ah, this is what up_list is about! I had no clue before that (from the name).

+1 for renaming (with deprecation of up_list), either in this patch or a followup.

For the name, for consistency with other spots (like bruhat_upper_covers), we should use a name like young_upper_covers or young_lattice_upper_covers.

You may want to raise a discussion on sage-combinat-devel to choose between the two.

Cheers,

Nicolas

comment:6 Changed 6 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.