Opened 11 years ago

Closed 7 years ago

#11295 closed defect (fixed)

FiniteField_givaroElement: make some methods private

Reported by: nbruin Owned by: cpernet
Priority: minor Milestone: sage-6.5
Component: finite rings Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Peter Bruin
Report Upstream: N/A Work issues:
Branch: fff80ed (Commits, GitHub, GitLab) Commit: fff80ed2653f9e0ac5f791a034b72cc04f495bb0
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The methods log_to_int, int_repr, log_repr and poly_repr should probably not be used by user code. Make them private (prepend an underscore) and deprecate the non-underscored versions.

Change History (9)

comment:1 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:4 Changed 8 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Component changed from documentation to finite rings
  • Description modified (diff)
  • Milestone changed from sage-6.4 to sage-6.5
  • Owner changed from mvngu to cpernet
  • Summary changed from FiniteField_givaroElement.log_to_int documentation to FiniteField_givaroElement: make some methods private

comment:6 Changed 8 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/11295
  • Modified changed from 11/25/14 13:52:28 to 11/25/14 13:52:28

comment:7 Changed 8 years ago by jdemeyer

  • Commit set to fff80ed2653f9e0ac5f791a034b72cc04f495bb0
  • Status changed from new to needs_review

New commits:

​fff80edMake some methods private

comment:8 Changed 8 years ago by pbruin

  • Reviewers set to Peter Bruin
  • Status changed from needs_review to positive_review

Looks good and passes tests.

comment:9 Changed 7 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/11295 to fff80ed2653f9e0ac5f791a034b72cc04f495bb0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.