Opened 10 years ago

Closed 10 years ago

#11294 closed defect (fixed)

Replace PyErr_CheckSignals() by sig_check

Reported by: jdemeyer Owned by: jdemeyer
Priority: major Milestone: sage-4.7.1
Component: c_lib Keywords: cython interrupt signal
Cc: Merged in: sage-4.7.1.alpha1
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

At various places in sage/matrix/, there is the following code:

    if PyErr_CheckSignals(): raise KeyboardInterrupt

Obviously, this is meant to implement some kind of sig_check(). Since sig_check() is specifically meant for this purpose, we should use sig_check() instead.

Attachments (1)

11294_sig_check.patch (3.1 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by jdemeyer

  • Description modified (diff)

Changed 10 years ago by jdemeyer

comment:2 Changed 10 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:3 Changed 10 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Sounds good!

comment:4 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.