Opened 6 years ago

Closed 6 years ago

#11293 closed enhancement (fixed)

All relations of a poset

Reported by: rbeezer Owned by: sage-combinat
Priority: minor Milestone: sage-4.7.1
Component: combinatorics Keywords: beginner, days30
Cc: saliola Merged in: sage-4.7.1.alpha1
Authors: Rob Beezer, Franco Saliola Reviewers: Franco Saliola, Rob Beezer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by rbeezer)

This adds methods for posets to create an iterator and a list, for all the relations of the poset (not just the cover relations).

Apply:

  1. trac_11293-all-relations-poset-v2.patch​

Attachments (3)

trac_11293-all-relations-poset.patch​ (2.5 KB) - added by rbeezer 6 years ago.
trac_11293-review.patch​ (1.4 KB) - added by saliola 6 years ago.
trac_11293-all-relations-poset-v2.patch​ (2.7 KB) - added by rbeezer 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by rbeezer

comment:1 Changed 6 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc saliola added
  • Description modified (diff)
  • Keywords beginner added
  • Status changed from new to needs_review

comment:2 Changed 6 years ago by saliola

Hello! I am going to upload a reviewer patch. By doing lookups in the lequal_matrix instead of using the is_less_than method, we get a speed-up in computation time.

Changed 6 years ago by saliola

Changed 6 years ago by rbeezer

comment:3 Changed 6 years ago by rbeezer

  • Authors changed from Rob Beezer to Rob Beezer, Franco Saliola
  • Description modified (diff)
  • Reviewers set to Franco Saliola, Rob Beezer

Franco's reviewer patch looks real good. So positive review on that part from me.

Franco also mentioned that we need to include the "diagonal relation", so the inner loop index has been adjusted to make that happen, and doctests updated. Then I rolled up the original patch, the reviewer patch, and the "diagonal" changes all into a single v2 patch.

comment:4 Changed 6 years ago by saliola

  • Keywords days30 added
  • Status changed from needs_review to positive_review

looks good to me

comment:5 Changed 6 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.