Opened 11 years ago
Closed 11 years ago
#11293 closed enhancement (fixed)
All relations of a poset
Reported by: | rbeezer | Owned by: | sage-combinat |
---|---|---|---|
Priority: | minor | Milestone: | sage-4.7.1 |
Component: | combinatorics | Keywords: | beginner, days30 |
Cc: | saliola | Merged in: | sage-4.7.1.alpha1 |
Authors: | Rob Beezer, Franco Saliola | Reviewers: | Franco Saliola, Rob Beezer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
This adds methods for posets to create an iterator and a list, for all the relations of the poset (not just the cover relations).
Apply:
Attachments (3)
Change History (8)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Cc saliola added
- Description modified (diff)
- Keywords beginner added
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
Changed 11 years ago by
Changed 11 years ago by
comment:3 Changed 11 years ago by
- Description modified (diff)
- Reviewers set to Franco Saliola, Rob Beezer
Franco's reviewer patch looks real good. So positive review on that part from me.
Franco also mentioned that we need to include the "diagonal relation", so the inner loop index has been adjusted to make that happen, and doctests updated. Then I rolled up the original patch, the reviewer patch, and the "diagonal" changes all into a single v2 patch.
comment:4 Changed 11 years ago by
- Keywords days30 added
- Status changed from needs_review to positive_review
looks good to me
comment:5 Changed 11 years ago by
- Merged in set to sage-4.7.1.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Hello! I am going to upload a reviewer patch. By doing lookups in the
lequal_matrix
instead of using theis_less_than
method, we get a speed-up in computation time.