Opened 10 years ago

Closed 10 years ago

#11292 closed enhancement (fixed)

Allow broader inputs to lattice meet and join

Reported by: rbeezer Owned by: sage-combinat
Priority: minor Milestone: sage-4.7.1
Component: combinatorics Keywords: beginner, days30
Cc: saliola Merged in: sage-4.7.1.alpha1
Authors: Rob Beezer Reviewers: Franco Saliola, Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rbeezer)

The meet and join methods of a lattice should be more robust about their inputs, like the is_lequal method is. 

sage: P = Posets.IntegerCompositions(4)
sage: L = LatticePoset(P)
sage: L.list()
[[4], [3, 1], [2, 2], [2, 1, 1], [1, 3], [1, 2, 1], [1, 1, 2], [1, 1, 1, 1]]
sage: L.meet([3,1], [1,2,1])
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<snip>
AttributeError: 'list' object has no attribute 'vertex'
sage: L.is_lequal([3,1], [1,2,1])
True

Apply:

  1. trac_11292-inputs-lattice-meet-join.patch​

Attachments (1)

trac_11292-inputs-lattice-meet-join.patch​ (2.2 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by rbeezer

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc saliola added
  • Description modified (diff)
  • Keywords beginner added
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by saliola

  • Keywords days30 added

comment:3 Changed 10 years ago by aschilling

  • Reviewers set to Franco Saliola, Anne Schilling
  • Status changed from needs_review to positive_review

comment:4 Changed 10 years ago by rbeezer

Thanks, Franco and Anne!

comment:5 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.