Opened 6 years ago
Closed 6 years ago
#11290 closed enhancement (fixed)
Implementation of non-commutative k-Schur functions in the nilCoxeter algebra
Reported by: | chrisjamesberg | Owned by: | chrisjamesberg |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7.1 |
Component: | combinatorics | Keywords: | kSchur, nilCoxeter algebra, days30 |
Cc: | sage-combinat, aschilling | Merged in: | sage-4.7.1.alpha1 |
Authors: | Chris Berg, Anne Schilling | Reviewers: | Jason Bandlow, Franco Saliola |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Implementation of the nilCoxeter algebra for all Weyl Groups. In affine type 'A' it computes the k-schur functions in non-commutative variables.
Attachments (2)
Change History (16)
comment:1 Changed 6 years ago by
- Keywords days30 added
comment:2 Changed 6 years ago by
- Component changed from PLEASE CHANGE to combinatorics
- Description modified (diff)
- Owner changed from tbd to sage-combinat
- Summary changed from Implementation of non-commutative k-Schur functions in the nil-Coxeter algebra. to Implementation of non-commutative k-Schur functions in the nilCoxeter algebra
comment:3 Changed 6 years ago by
- Description modified (diff)
comment:4 Changed 6 years ago by
- Status changed from new to needs_review
comment:5 Changed 6 years ago by
- Reviewers set to Jason Bandlow
- Status changed from needs_review to positive_review
comment:6 Changed 6 years ago by
- Description modified (diff)
- Owner changed from sage-combinat to chrisjamesberg
comment:7 Changed 6 years ago by
- Description modified (diff)
comment:8 Changed 6 years ago by
- Status changed from positive_review to needs_work
There is a problem with the patch: applies cleanly, builds fine, but I got an import error on startup:
ImportError: No module named nil_coxeter_algebra
Chris, perhaps you forgot to add your nil_coxeter_algebra.py
file to the patch?
comment:9 Changed 6 years ago by
For the latest patch, all doctests pass, and coverage is at 100%.
But, I think there will be a problem building the documentation unless the following line in algebra.rst is updated appropriately:
../sage/algebras/nil_coxeter
comment:10 Changed 6 years ago by
- Status changed from needs_work to positive_review
Thanks Franco for the report! This should be fixed now.
Chris, I also modified the documentation of the k_schur_noncommutative_variables, since it now only works for affine type A, but the documentation had not been updated.
I set it back to positive review since all issues were fixed.
Anne
Apply: trac_11290-nilCoxeter-final.patch
Changed 6 years ago by
comment:11 Changed 6 years ago by
I fixed one more unnecessary import from WeylGroups? in the patch and posted the new version.
Anne
Apply: trac_11290-nilCoxeter-final.patch
comment:12 Changed 6 years ago by
- Reviewers changed from Jason Bandlow to Jason Bandlow, Franco Saliola
comment:13 Changed 6 years ago by
- Description modified (diff)
comment:14 Changed 6 years ago by
- Merged in set to sage-4.7.1.alpha1
- Resolution set to fixed
- Status changed from positive_review to closed
This iteration looks good to me, Chris. Positive review!