Opened 8 years ago

Closed 8 years ago

#11279 closed enhancement (fixed)

Convex Hulls, Hull number in graphs

Reported by: ncohen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-4.8
Component: graph theory Keywords:
Cc: Merged in: sage-4.8.alpha2
Authors: Nathann Cohen Reviewers: Leonardo Sampaio
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ncohen)

This ticket implements a method to compute the hull number of a graph. As it requires to compute many convex hulls, a corresponding hull method is defined too. As computing many hulls is a mess unless you can cache some useful information, these methods are defined inside of a convexity_properties class, which I hope I documented enough :-)

If you feel some things are badly named or should be rearranged, please tell me. I thought about this code for a while, and even though it works somehow well I am still not satisfied with it :-)

(The file convexity_properties is added to the reference manual, and explains most of what the code does)

Nathann

Requires:

Apply:

Attachments (1)

trac_11279.patch (21.8 KB) - added by ncohen 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by ncohen

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by lsampaio

  • Status changed from needs_review to positive_review

The patch is working and I believe it should be merged into sage.

comment:3 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work

This conflicts with #11994.

comment:4 Changed 8 years ago by ncohen

  • Description modified (diff)
  • Status changed from needs_work to positive_review

Right ! It's now rebased on top of #11944, in Sage 4.8.alpha0 :-)

Nathann

comment:5 Changed 8 years ago by ncohen

  • Description modified (diff)

comment:6 Changed 8 years ago by jdemeyer

  • Reviewers set to Leonardo Sampaio

comment:7 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work

There is a small issue with the formatting of the documentation:

docstring of sage.graphs.convexity_properties.ConvexityProperties:29: (WARNING/2) Inline emphasis start-string without end-string.

comment:8 Changed 8 years ago by ncohen

  • Status changed from needs_work to positive_review

Sorry about that ! It's fixed in the updated version :-)

Nathann

Changed 8 years ago by ncohen

comment:9 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.8.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.