Opened 11 years ago

Closed 9 years ago

#11276 closed defect (duplicate)

bug in documentation for non_surjective for Galois representations attached to elliptic curves

Reported by: David Pathakjee Owned by: John Cremona
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: elliptic curves Keywords: galois representation, elliptic curves, non_surjective, documentation
Cc: William Stein Merged in:
Authors: Reviewers: Chris Wuthrich
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Frédéric Chapoton)

non_surjective() docstring incorrectly states that it's inconclusive and often wrong for p=2. The function it calls, is_surjective, is correct for p=2.

The docstring states that "[the] list of primes p such that the mod-p representation *might* not be surjective... usually contains 2, because of shortcomings of the algorithm..." However, non_surjective calls is_surjective, which should always be correct for p=2,3 because it computes the Galois group of the 2-division polynomial. (More precisely, its helper, _is_surjective, does this.) I suspect this caveat may have been written before the special cases for p=2,3 in _is_surjective had been written.

All that really needs to be done is to remove the phrase "(this list usually contains 2, because of shortcomings of the algorithm)" from the docstring.

See also #11271, #11270

Change History (5)

comment:1 Changed 9 years ago by Frédéric Chapoton

Description: modified (diff)

comment:2 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:3 Changed 9 years ago by wuthrich

Milestone: sage-6.1sage-duplicate/invalid/wontfix
Status: newneeds_review

This is a duplicate (well, striclty speaking a sub-ticket) of #11271. This should be closed.

comment:4 Changed 9 years ago by Peter Bruin

Reviewers: Chris Wuthrich
Status: needs_reviewpositive_review

comment:5 Changed 9 years ago by Volker Braun

Resolution: duplicate
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.