Sage: Ticket #11230: Define our own PariOUT
https://trac.sagemath.org/ticket/11230
<p>
Instead of changing <code>defaultOut</code> in <code>sage/libs/pari/gen.pyx</code>, we should instead define our own <code>PariOUT</code> structure and use that.
</p>
en-usSagehttps://trac.sagemath.org/chrome/site/logo_sagemath_trac.png
https://trac.sagemath.org/ticket/11230
Trac 1.1.6jdemeyerThu, 21 Apr 2011 08:56:43 GMTattachment set
https://trac.sagemath.org/ticket/11230
https://trac.sagemath.org/ticket/11230
<ul>
<li><strong>attachment</strong>
set to <em>11230_pariout.patch</em>
</li>
</ul>
TicketjdemeyerThu, 21 Apr 2011 09:08:06 GMTstatus changed
https://trac.sagemath.org/ticket/11230#comment:1
https://trac.sagemath.org/ticket/11230#comment:1
<ul>
<li><strong>status</strong>
changed from <em>new</em> to <em>needs_review</em>
</li>
</ul>
TicketrobertwbSat, 23 Apr 2011 04:43:35 GMTstatus changed
https://trac.sagemath.org/ticket/11230#comment:2
https://trac.sagemath.org/ticket/11230#comment:2
<ul>
<li><strong>status</strong>
changed from <em>needs_review</em> to <em>positive_review</em>
</li>
</ul>
<p>
LGTM, pending adding the trac number to the ticket description.
</p>
<p>
Why in the world did we define <code>__x</code> to do <code>ctypedef __x pariout_t</code>?
</p>
TicketjdemeyerSun, 24 Apr 2011 18:39:55 GMTreviewer set
https://trac.sagemath.org/ticket/11230#comment:3
https://trac.sagemath.org/ticket/11230#comment:3
<ul>
<li><strong>reviewer</strong>
set to <em>Robert Bradshaw</em>
</li>
</ul>
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:2" title="Comment 2">robertwb</a>:
</p>
<blockquote class="citation">
<p>
LGTM, pending adding the trac number to the ticket description.
</p>
</blockquote>
<p>
This is no longer necessary (see <a class="ext-link" href="http://groups.google.com/group/sage-devel/browse_thread/thread/f5a9c012f6299a9e/a3c2af4a7700bca3"><span class="icon"></span>http://groups.google.com/group/sage-devel/browse_thread/thread/f5a9c012f6299a9e/a3c2af4a7700bca3</a>)
</p>
<blockquote class="citation">
<p>
Why in the world did we define <code>__x</code> to do <code>ctypedef __x pariout_t</code>?
</p>
</blockquote>
<p>
I didn't write that code, but probably to work around some limitation/bug in an earlier version of Cython?
</p>
TicketcremonaMon, 25 Apr 2011 11:44:22 GMTstatus changed
https://trac.sagemath.org/ticket/11230#comment:4
https://trac.sagemath.org/ticket/11230#comment:4
<ul>
<li><strong>status</strong>
changed from <em>positive_review</em> to <em>needs_info</em>
</li>
</ul>
<p>
I know this has a positive review from the omnipotent testbot, but when I apply this to a freshly-rolled 4.7.alpha5 and do a full test I get two failures in sage/misc/sagedoc.py:
</p>
<pre class="wiki">File "/home/jec/sage-4.7.alpha5.pari/devel/sage-main/sage/misc/sagedoc.py", line 874:
sage: len(search_doc('tree', interact=False).splitlines()) > 2500 # long time
Expected:
True
Got:
False
**********************************************************************
File "/home/jec/sage-4.7.alpha5.pari/devel/sage-main/sage/misc/sagedoc.py", line 489:
sage: 'abvar/homology' in _search_src_or_doc('doc', 'homology', 'variety', interact=False)
Expected:
True
Got:
False
</pre><p>
I built Sage with "make build" rather than "make", in case that is relevant. Meanwhile I switched the tag to "needs info" but will continue with this applied and go on to <a class="closed ticket" href="https://trac.sagemath.org/ticket/11130" title="defect: Update PARI to version 2.5.0 (closed: fixed)">#11130</a>.
</p>
TicketjdemeyerMon, 25 Apr 2011 11:48:55 GMT
https://trac.sagemath.org/ticket/11230#comment:5
https://trac.sagemath.org/ticket/11230#comment:5
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:4" title="Comment 4">cremona</a>:
</p>
<blockquote class="citation">
<p>
I built Sage with "make build" rather than "make", in case that is relevant.
</p>
</blockquote>
<p>
Probably it is, because the doctest failures you mention are related to the <strong>documentation</strong>. So I would guess that <code>make doc-html</code> would solve those problems.
</p>
TicketcremonaMon, 25 Apr 2011 11:50:20 GMT
https://trac.sagemath.org/ticket/11230#comment:6
https://trac.sagemath.org/ticket/11230#comment:6
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:5" title="Comment 5">jdemeyer</a>:
</p>
<blockquote class="citation">
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:4" title="Comment 4">cremona</a>:
</p>
<blockquote class="citation">
<p>
I built Sage with "make build" rather than "make", in case that is relevant.
</p>
</blockquote>
<p>
Probably it is, because the doctest failures you mention are related to the <strong>documentation</strong>. So I would guess that <code>make doc-html</code> would solve those problems.
</p>
</blockquote>
<p>
I guessed so, so am about to try again after sage -docbuild all html has finished...
</p>
TicketcremonaMon, 25 Apr 2011 13:11:46 GMTstatus changed
https://trac.sagemath.org/ticket/11230#comment:7
https://trac.sagemath.org/ticket/11230#comment:7
<ul>
<li><strong>status</strong>
changed from <em>needs_info</em> to <em>needs_review</em>
</li>
</ul>
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:6" title="Comment 6">cremona</a>:
</p>
<blockquote class="citation">
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:5" title="Comment 5">jdemeyer</a>:
</p>
<blockquote class="citation">
<p>
Replying to <a class="ticket" href="https://trac.sagemath.org/ticket/11230#comment:4" title="Comment 4">cremona</a>:
</p>
<blockquote class="citation">
<p>
I built Sage with "make build" rather than "make", in case that is relevant.
</p>
</blockquote>
<p>
Probably it is, because the doctest failures you mention are related to the <strong>documentation</strong>. So I would guess that <code>make doc-html</code> would solve those problems.
</p>
</blockquote>
<p>
I guessed so, so am about to try again after sage -docbuild all html has finished...
</p>
</blockquote>
<p>
As expected, the problem went away. I suppose it was silly to base the full test on devel/sage and not devel/sage/sage given that I had not built the docs.
</p>
TicketcremonaMon, 25 Apr 2011 13:11:59 GMTstatus, reviewer changed
https://trac.sagemath.org/ticket/11230#comment:8
https://trac.sagemath.org/ticket/11230#comment:8
<ul>
<li><strong>status</strong>
changed from <em>needs_review</em> to <em>positive_review</em>
</li>
<li><strong>reviewer</strong>
changed from <em>Robert Bradshaw</em> to <em>Robert Bradshaw, John Cremona</em>
</li>
</ul>
TicketjdemeyerTue, 26 Apr 2011 09:05:40 GMTstatus changed; resolution, merged set
https://trac.sagemath.org/ticket/11230#comment:9
https://trac.sagemath.org/ticket/11230#comment:9
<ul>
<li><strong>status</strong>
changed from <em>positive_review</em> to <em>closed</em>
</li>
<li><strong>resolution</strong>
set to <em>fixed</em>
</li>
<li><strong>merged</strong>
set to <em>sage-4.7.1.alpha0</em>
</li>
</ul>
Ticket