Opened 11 years ago

Closed 11 years ago

#11227 closed defect (fixed)

gcc-4.6.0 optimization bug with cliquer-1.2.p7.spkg

Reported by: mariah Owned by: mariah
Priority: blocker Milestone: sage-4.7
Component: packages: standard Keywords: cliquer spkg
Cc: Merged in: sage-4.7.rc2
Authors: Jeroen Demeyer Reviewers: Mariah Lenox
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

On various 64-bit x86_64 Linux machines (for example, the Skynet machine eno), sage-4.7.alpha5 built with gcc-4.6.0 fails various tests with a timeout:

sage -t -long  -force_lib devel/sage/sage/graphs/graph_generators.py # Time out
sage -t -long  -force_lib devel/sage/sage/graphs/graph_coloring.py # Time out
sage -t -long  -force_lib devel/sage/sage/graphs/graph.py # Time out
sage -t -long  -force_lib devel/sage/sage/graphs/cliquer.pyx # Time out

The problem can be seen by executing the following command, which should take milliseconds but simply hangs instead:

sage: clique_number(Graph({0:[1,2,3], 1:[2], 3:[0,1]}))

New spkg adding flag -fno-ivopts: http://boxen.math.washington.edu/home/jdemeyer/spkg/cliquer-1.2.p9.spkg

Fixed upstream: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48774

For other gcc 4.6.0 specific problems see #11216.

Attachments (2)

cliquer-1.2.p7-p8.diff (4.1 KB) - added by jdemeyer 11 years ago.
Diff for the cliquer spkg, for reviewing only
cliquer-1.2.p8-p9.diff (1.6 KB) - added by jdemeyer 11 years ago.
Diff for the cliquer spkg, for reviewing only

Download all attachments as: .zip

Change History (19)

comment:1 Changed 11 years ago by mariah

  • Milestone set to sage-4.7.1
  • Owner changed from tbd to mariah

The following code triggers the problem (code does not return):

sage: g = graphs.BidiakisCube();
sage: g.clique_number()

If cliquer-1.2.p7.spkg is rebuilt with -O1 rather than -O2, then the problem goes away.

comment:2 Changed 11 years ago by mariah

If src/reorder.c is built with -O1 rather than -O2, then the problem goes away.

comment:3 follow-up: Changed 11 years ago by drkirkby

  • Description modified (diff)

On what platform is this problem?

Dave

comment:4 in reply to: ↑ 3 Changed 11 years ago by mariah

Replying to drkirkby:

On what platform is this problem?

Dave

Apologies for not mentioning this. I see the problem on skynet:eno (x86_64-Linux-core2). I have not checked to see if the problem exists on other architectures.

comment:5 Changed 11 years ago by jdemeyer

  • Description modified (diff)
  • Keywords cliquer added

comment:6 Changed 11 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 11 years ago by jdemeyer

-fno-ivopts also fixes this (just like #11168).

comment:8 Changed 11 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Milestone changed from sage-4.7.1 to sage-4.7
  • Priority changed from major to blocker
  • Status changed from new to needs_review

Changed 11 years ago by jdemeyer

Diff for the cliquer spkg, for reviewing only

comment:9 Changed 11 years ago by mariah

  • Report Upstream changed from N/A to Reported upstream. Little or no feedback.
  • Reviewers set to Mariah Lenox
  • Status changed from needs_review to positive_review

Reported upstream to gcc bugzilla, see | #48774

Tested on sage-4.7.rc0 on skynet/eno (x86_64-Linux-core2). All tests passed. Positive review.

comment:10 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.rc1
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 11 years ago by mariah

  • Report Upstream changed from Reported upstream. Little or no feedback. to Reported upstream. Developers acknowledge bug.

comment:12 Changed 11 years ago by jdemeyer

  • Merged in sage-4.7.rc1 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

comment:13 Changed 11 years ago by jdemeyer

  • Description modified (diff)
  • Keywords spkg added
  • Status changed from new to needs_review

comment:14 Changed 11 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release.
  • Status changed from needs_review to needs_work

comment:15 Changed 11 years ago by jdemeyer

  • Status changed from needs_work to needs_review

Changed 11 years ago by jdemeyer

Diff for the cliquer spkg, for reviewing only

comment:16 Changed 11 years ago by mariah

  • Status changed from needs_review to positive_review

cliquer-1.2.p9 applied to sage-4.7.rc1 and built with 'make testlong' on skynet/eno. All tests passed. Positive review.

comment:17 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.rc2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.