Opened 7 years ago

Closed 6 years ago

#11183 closed enhancement (fixed)

Stembridge local characterization for crystal bases

Reported by: sdenton Owned by: sage-combinat
Priority: major Milestone: sage-4.7.2
Component: combinatorics Keywords: crystals
Cc: sage-combinat, aschilling Merged in: sage-4.7.2.alpha1
Authors: Tom Denton Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Implementation of the Stembridge local axioms for crystal bases. Some functions added for checking these axioms, and _test_stembridge_local_axioms() was added to the test suite for highest weight crystals.

Attachments (2)

trac_11183-crystals_local_characterization-td.patch (17.8 KB) - added by sdenton 7 years ago.
exported patch file
trac_11183-crystals_local_characterization-final.patch (25.9 KB) - added by aschilling 6 years ago.

Download all attachments as: .zip

Change History (14)

Changed 7 years ago by sdenton

exported patch file

comment:1 Changed 7 years ago by aschilling

  • Reviewers set to Anne Schilling
  • Status changed from new to needs_review

comment:2 Changed 7 years ago by aschilling

  • Status changed from needs_review to positive_review

This patch implements the local axioms for highest weight crystals of simply-laced types. This is a very useful test to check that a given crystal is actually consistent (for simply-laced types these tests are necessary and sufficient, for nonsimply-laced types only necessary). I tested this patch mathematically on several crystals.

sage -t on all relevant crystal code passes. If the buildbot gives green light for all tests, this is a positive review!

comment:3 Changed 7 years ago by aschilling

  • Status changed from positive_review to needs_work

Currently, the tests in /sage/categories/examples/crystals.py do not pass and need to be updated. In addition, it would be good to provide an implementation of a simple "crystal" that does not pass the Stembridge tests in this file.

So I set this to "needs work".

Anne

comment:4 Changed 6 years ago by aschilling

  • Status changed from needs_work to positive_review

I reviewed the final version of the patch and it looks good now! The tests of all modified files pass. If the buildbot gives a green light, this has a positive review!

Anne

Apply: trac_11183-crystals_local_characterization-final.patch

comment:5 Changed 6 years ago by jdemeyer

  • Authors changed from tom denton to Tom Denton
  • Milestone changed from sage-4.7.1 to sage-4.7.2

comment:6 follow-up: Changed 6 years ago by nthiery

Note: I had to (trivially) rebase #10998 on top of this patch. Please check that the queue apply next time :-)

comment:7 in reply to: ↑ 6 Changed 6 years ago by nthiery

Replying to nthiery:

Note: I had to (trivially) rebase #10998 on top of this patch. Please check that the queue apply next time :-)

Oops, #9280 in fact.

comment:8 follow-up: Changed 6 years ago by jdemeyer

  • Status changed from positive_review to needs_work

The first line of the patch file is

exporting patch:

This should not be there. Probably you made some script which writes such a line, I think it is best to undo that.

comment:9 follow-up: Changed 6 years ago by jdemeyer

Also, there are some problems building the documentation:

dochtml.log:/mnt/usb1/scratch/jdemeyer/merger/sage-4.7.2.alpha1/devel/sage/doc/en/reference/sage/categories/examples/crystals.rst:69: WARNING: more than one target found for cross-reference u'cartan_type': sage.combinat.crystals.tensor_product.CrystalOfTableaux.cartan_type, sage.combinat.root_system.dynkin_diagram.DynkinDiagram_class.cartan_type, sage.combinat.root_system.weyl_characters.WeightRing.cartan_type, sage.combinat.root_system.weyl_characters.WeylCharacterRing.cartan_type, sage.combinat.root_system.weyl_group.WeylGroup_gens.cartan_type, sage.combinat.root_system.root_system.RootSystem.cartan_type, sage.algebras.iwahori_hecke_algebra.IwahoriHeckeAlgebraT.cartan_type, sage.categories.crystals.Crystals.ParentMethods.cartan_type, sage.combinat.root_system.weyl_group.ClassicalWeylSubgroup.cartan_type, sage.combinat.root_system.weyl_characters.WeylCharacterRing.Element.cartan_type, sage.combinat.root_system.weyl_characters.WeightRing.Element.cartan_type, sage.categories.crystals.Crystals.ElementMethods.cartan_type
dochtml.log:/mnt/usb1/scratch/jdemeyer/merger/sage-4.7.2.alpha1/devel/sage/doc/en/reference/sage/categories/examples/crystals.rst:73: WARNING: more than one target found for cross-reference u'Element.weight': sage.combinat.crystals.direct_sum.DirectSumOfCrystals.Element.weight, sage.combinat.crystals.fast_crystals.FastCrystal.Element.weight

comment:10 in reply to: ↑ 8 Changed 6 years ago by aschilling

Replying to jdemeyer:

The first line of the patch file is

exporting patch:

This should not be there. Probably you made some script which writes such a line, I think it is best to undo that.

This spurious line was removed in the revised patch.

Best wishes,

Anne

comment:11 in reply to: ↑ 9 Changed 6 years ago by aschilling

  • Status changed from needs_work to positive_review

Replying to jdemeyer:

Also, there are some problems building the documentation:

dochtml.log:/mnt/usb1/scratch/jdemeyer/merger/sage-4.7.2.alpha1/devel/sage/doc/en/reference/sage/categories/examples/crystals.rst:69: WARNING: more than one target found for cross-reference u'cartan_type': sage.combinat.crystals.tensor_product.CrystalOfTableaux.cartan_type, sage.combinat.root_system.dynkin_diagram.DynkinDiagram_class.cartan_type, sage.combinat.root_system.weyl_characters.WeightRing.cartan_type, sage.combinat.root_system.weyl_characters.WeylCharacterRing.cartan_type, sage.combinat.root_system.weyl_group.WeylGroup_gens.cartan_type, sage.combinat.root_system.root_system.RootSystem.cartan_type, sage.algebras.iwahori_hecke_algebra.IwahoriHeckeAlgebraT.cartan_type, sage.categories.crystals.Crystals.ParentMethods.cartan_type, sage.combinat.root_system.weyl_group.ClassicalWeylSubgroup.cartan_type, sage.combinat.root_system.weyl_characters.WeylCharacterRing.Element.cartan_type, sage.combinat.root_system.weyl_characters.WeightRing.Element.cartan_type, sage.categories.crystals.Crystals.ElementMethods.cartan_type
dochtml.log:/mnt/usb1/scratch/jdemeyer/merger/sage-4.7.2.alpha1/devel/sage/doc/en/reference/sage/categories/examples/crystals.rst:73: WARNING: more than one target found for cross-reference u'Element.weight': sage.combinat.crystals.direct_sum.DirectSumOfCrystals.Element.weight, sage.combinat.crystals.fast_crystals.FastCrystal.Element.weight

The two warnings should be fixed in the revised patch.

Best wishes,

Anne

comment:12 Changed 6 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.