Opened 9 years ago

Closed 9 years ago

#11156 closed defect (fixed)

sage.misc.sage_unittest.InstanceTester should call its base's __init__

Reported by: nthiery Owned by: mvngu
Priority: major Milestone: sage-4.7
Component: doctest coverage Keywords: TestSuite
Cc: fbissey Merged in: sage-4.7.alpha5
Authors: Nicolas M. Thiéry Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by fbissey)

The following patch fixes sage.misc.sage_unittest.InstanceTester? to call it's base's init as requested by the documentation of unittest.TestCase?. This was harmless with Python 2.6, but breaks e.g. assertEqual with the new version of unittest in Python 2.7. See: http://groups.google.com/group/sage-devel/browse_thread/thread/e008180354a150f3

Apply:

Attachments (1)

trac_11156-sage_unittest-init-nt.patch (711 bytes) - added by nthiery 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by nthiery

comment:1 Changed 9 years ago by nthiery

  • Status changed from new to needs_review
  • Summary changed from sage.misc.sage_unittest.InstanceTester does not call it's base __init__ to sage.misc.sage_unittest.InstanceTester should call its base's __init__

comment:2 Changed 9 years ago by fbissey

  • Cc fbissey added

comment:3 Changed 9 years ago by fbissey

It prove effective on python-2.7 enabled sage. I will test it as well on a vanilla sage to make sure there are no side effects (there shouln't be). Thanks for the patch, it really brings us very close to sage running on python-2.7.

comment:4 Changed 9 years ago by fbissey

  • Description modified (diff)
  • Status changed from needs_review to positive_review

No side effects. I am giving this a positive review. Can we have it in 4.7 pretty please?

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.