Opened 11 years ago

Closed 10 years ago

#11144 closed defect (fixed)

trivial typo messes up interact doc

Reported by: kcrisman Owned by: mvngu
Priority: trivial Milestone: sage-4.7.2
Component: notebook Keywords: notebook
Cc: mvngu Merged in: sage-4.7.2.alpha1
Authors: Ivo Hedtke Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

The doc for is_auto_update at this page shows that there is an underscore that is formatting a 'u' incorrectly. Probably this is a one-or-two-character fix, though I haven't checked it out. Most likely someone used `` instead of `?

Apply 11144_sagenb.patch to sagenb.

Attachments (2)

trac_11144.patch (886 bytes) - added by hedtke 10 years ago.
11144_sagenb.patch (813 bytes) - added by jdemeyer 10 years ago.
Patch for SAGENB

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by hedtke

comment:1 Changed 10 years ago by hedtke

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by hedtke

  • Milestone set to sage-4.7.1

comment:3 follow-ups: Changed 10 years ago by jhpalmieri

  • Authors set to Ivo Hedtke
  • Description modified (diff)
  • Keywords notebook added; beginner removed
  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

You've patched the wrong file, SAGE_ROOT/devel/sage/sage/server/notebook/interact.py. Note that this file says at the top

# This file is part of the OLD Sage notebook and is NOT actively developed,
# maintained, or supported.  As of Sage v4.1.2, all notebook development has
# moved to the separate Sage Notebook project:
#
# http://nb.sagemath.org/

I've posted it instead as a patch for the sagenb project instead: see https://code.google.com/p/sagenb/issues/detail?id=41.

To the release manager: I think we should close this ticket as invalid, since it's for the Sage notebook, not the Sage library. Do not apply the patch here.

comment:4 in reply to: ↑ 3 Changed 10 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Replying to jhpalmieri:

To the release manager: I think we should close this ticket as invalid, since it's for the Sage notebook, not the Sage library. Do not apply the patch here.

It is still not at all clear to me whether there is even something as a "sagenb project" unfortunately. I will attach a proper sagenb patch.

Changed 10 years ago by jdemeyer

Patch for SAGENB

comment:5 Changed 10 years ago by jdemeyer

  • Component changed from documentation to notebook
  • Description modified (diff)
  • Milestone changed from sage-4.7.1 to sage-4.7.2
  • Status changed from needs_work to needs_review

comment:6 Changed 10 years ago by jdemeyer

See also #11409 for avoiding people to patch to wrong files.

comment:7 in reply to: ↑ 3 Changed 10 years ago by jdemeyer

  • Status changed from needs_review to positive_review

Replying to jhpalmieri:

I've posted it instead as a patch for the sagenb project instead: see https://code.google.com/p/sagenb/issues/detail?id=41.

I am waiting for clarification on this situation at http://groups.google.com/group/sage-notebook/browse_thread/thread/5f8ee7606e0d94bd

The patch itself obviously gets positive_review.

comment:8 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-4.7.2 to sage-pending

comment:9 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-pending to sage-4.7.2

comment:10 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.2.alpha1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.