Opened 11 years ago
Closed 11 years ago
#11108 closed enhancement (fixed)
Improve class_graph
Reported by: | nthiery | Owned by: | jason |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7.1 |
Component: | misc | Keywords: | class, inheritance, graph |
Cc: | ncohen, sage-combinat | Merged in: | sage-4.7.1.alpha0 |
Authors: | Nicolas M. Thiéry | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Improvements to class_graph:
- Returns directly a DiGraph? by default
- Supports a class or an object as input
- Improves the doc
Apply :
- trac_11108-classgraph-nt.patch
Attachments (2)
Change History (9)
comment:1 Changed 11 years ago by
- Status changed from new to needs_review
comment:2 Changed 11 years ago by
- Description modified (diff)
Changed 11 years ago by
comment:3 Changed 11 years ago by
- Description modified (diff)
comment:4 Changed 11 years ago by
- Description modified (diff)
- Reviewers set to Nathann Cohen
Hi Nathann,
Thanks for your review! The comments were welcome indeed :-) I rephrased them just a bit, and folded your patch into yours.
No comment on sage-devel, so I guess noone cares.
Cheers,
Nicolas
comment:5 Changed 11 years ago by
- Status changed from needs_review to positive_review
Great ! This one's good to go ! I wanted to check the documentation again but Sage does not like to have some file added in a branch that disappear in another :-)
Nathann
comment:6 Changed 11 years ago by
- Milestone changed from sage-4.7 to sage-4.7.1
comment:7 Changed 11 years ago by
- Merged in set to sage-4.7.1.alpha0
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Hello !!!
Here is a small patch adding 3 lines of comments to your code, so that other will understand it faster than I did
:-)
If that's fine with you, you can set the ticket to "positive review" !
Nathann