Opened 11 years ago
Closed 10 years ago
#11078 closed defect (fixed)
jmol in the flask notebook
Reported by: | jason | Owned by: | jason, mpatel, was |
---|---|---|---|
Priority: | major | Milestone: | sage-5.2 |
Component: | notebook | Keywords: | sd31 sd35.5 |
Cc: | rkirov, mhansen, kcrisman | Merged in: | sage-5.2.beta0 |
Authors: | William Stein, Jonathan Gutow | Reviewers: | Jason Grout |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #11080 | Stopgaps: |
Description (last modified by )
The attached patch solves an issue with jmol finding the right .jmol.zip file in the new flask notebook. This patch should only be applied *after* the notebook is moved to a flask notebook.
The patch should replace the following line in sage/plot/plot3d/base.pyx
f.write('set defaultdirectory "%s"\n' % archive_name)
with
import sagenb f.write('set defaultdirectory "cells/%s/%s"\n' % (sagenb.notebook.interact.SAGE_CELL_ID, archive_name))
Attachments (1)
Change History (21)
comment:1 Changed 11 years ago by
- Cc kcrisman added
comment:2 Changed 11 years ago by
- Description modified (diff)
comment:3 Changed 11 years ago by
- Keywords sd31 added
comment:4 Changed 11 years ago by
comment:5 Changed 10 years ago by
- Milestone changed from sage-4.8 to sage-5.0
comment:6 Changed 10 years ago by
- Description modified (diff)
Changed 10 years ago by
comment:7 Changed 10 years ago by
- Reviewers set to Jason Grout
- Status changed from new to needs_review
I updated the patch with the changes from #11503. With the flask notebook, sphere() works both from the command line and from the notebook.
I'm setting as needs review to have one other person double-check this patch works as intended, though I guess I might qualify as the only needed reviewer. Basically, what I did here was just rebase the patch at #11503.
comment:8 Changed 10 years ago by
- Status changed from needs_review to positive_review
This looks great to me!
comment:9 Changed 10 years ago by
- Dependencies set to #11080
comment:10 Changed 10 years ago by
- Keywords sd35.5 added
comment:11 Changed 10 years ago by
- Keywords changed from sd31, sd35.5 to sd31 sd35.5
comment:12 Changed 10 years ago by
- Milestone changed from sage-5.0 to sage-pending
comment:13 Changed 10 years ago by
- Milestone changed from sage-pending to sage-5.1
comment:14 Changed 10 years ago by
- Milestone changed from sage-5.1 to sage-pending
comment:15 Changed 10 years ago by
- Milestone changed from sage-pending to sage-5.2
comment:16 Changed 10 years ago by
- Merged in set to sage-5.2.beta0
- Resolution set to fixed
- Status changed from positive_review to closed
comment:17 Changed 10 years ago by
- Merged in sage-5.2.beta0 deleted
- Milestone changed from sage-5.2 to sage-pending
- Resolution fixed deleted
- Status changed from closed to new
Unmerging this from sage-5.2 due to the serious security issue at #13270.
comment:18 Changed 10 years ago by
- Status changed from new to needs_review
comment:19 Changed 10 years ago by
- Status changed from needs_review to positive_review
comment:20 Changed 10 years ago by
- Merged in set to sage-5.2.beta0
- Milestone changed from sage-pending to sage-5.2
- Resolution set to fixed
- Status changed from positive_review to closed
This week, I compiled sage-4.7.1.rc0 and installed the new flask Sage notebook following instructions from : http://code.google.com/r/rkirov-flask/. I also followed the section
Adding stock Jmol
plus the patchtrac_11078.patch
. This made Jmol to work from the notebook : Great!But, from the command line, with the patch
trac_11078.patch
a command likesphere()
opens Jmol but Jmol stays all black. I had to mimic the modifications done in #11503 on the same filesage/plot/plot3d/base.pyx
to make Jmol works properly from the command line.Sébastien