Opened 10 years ago

Closed 10 years ago

#11052 closed defect (fixed)

Bad shell logic in root-spkg-install

Reported by: jdemeyer Owned by:
Priority: critical Milestone: sage-4.7
Component: scripts Keywords: sage_root
Cc: vbraun Merged in: sage-4.7.alpha3
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

The following piece of root-spkg-install doesn't work as intented, because the $? refers to the exit status of the first if instead of hg incoming:

    # Merge the repository, rather than overwrite changes that the
    # user may have made.
    hg incoming "$CUR" 1> /dev/null
    if [ $? -eq 1 ]; then
        # No changes to pull
        exit 0
    fi
    if [ $? -ne 0 ]; then
        echo "Error with Sage root repository: 'hg incoming' failed."
        exit 1
    fi

Attachments (1)

11052.patch (870 bytes) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by jdemeyer

comment:1 Changed 10 years ago by jdemeyer

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by vbraun

  • Status changed from needs_review to positive_review

Good catch!

comment:3 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha3
  • Resolution set to fixed
  • Reviewers set to Volker Braun
  • Status changed from positive_review to closed

Thanks Volker.

Note: See TracTickets for help on using tickets.