Opened 12 years ago
Closed 18 months ago
#11043 closed defect (invalid)
Lazily import plot.
Reported by: | Robert Bradshaw | Owned by: | Jason Grout |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | misc | Keywords: | sd32 |
Cc: | Karl-Dieter Crisman | Merged in: | |
Authors: | Reviewers: | Dima Pasechnik | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Improve startup time.
Attachments (3)
Change History (17)
Changed 12 years ago by
Attachment: | 11043-lazy-plot.patch added |
---|
comment:1 Changed 12 years ago by
Description: | modified (diff) |
---|---|
Status: | new → needs_review |
Changed 11 years ago by
Attachment: | 11043-lazy-plot-rebase4.7.1.patch added |
---|
comment:2 Changed 11 years ago by
Status: | needs_review → needs_work |
---|
comment:3 Changed 11 years ago by
Status: | needs_work → needs_review |
---|
This is a more conservative patch which only saves importing the plot.* modules (about a 50-100ms savings on my computer).
comment:4 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Summary: | Lazily import plot, numpy, etc. → Lazily import plot. |
comment:5 Changed 11 years ago by
Status: | needs_review → needs_work |
---|
Robert, did you even test this? It seems to fail doctests all over the place. E.g.,
sage -t devel/sage/sage/calculus/riemann.pyx ********************************************************************** File "/mnt/usb1/scratch/wstein/sage-4.7.1-sage.math.washington.edu-x86_64-Linux/devel/sage-main/sage/calculus/riemann.pyx", line 114: sage: m = Riemann_Map([f, hf], [hf, hfprime], 0.5 + 0.5*I) Exception raised: Traceback (most recent call last): File "/mnt/usb1/scratch/wstein/sage-4.7.1-sage.math.washington.edu-x86_64-Linux/local/bin/ncadoctest.p ... ImportError: No module named riemann
It seems like using LazyImport? in any nontrivial way always results in serious breakage that is revealed by doctests. I hit this numerous times myself. Hmmm.
comment:6 Changed 11 years ago by
Keywords: | sd32 added |
---|
comment:7 Changed 11 years ago by
Is anything happening on this? Robert wrote the patch, William says it breaks doctests all over the place, but then it just stalls.
Dave
comment:8 Changed 11 years ago by
Cc: | Karl-Dieter Crisman added |
---|
comment:9 Changed 9 years ago by
Milestone: | sage-5.11 → sage-5.12 |
---|
comment:10 Changed 9 years ago by
Milestone: | sage-6.1 → sage-6.2 |
---|
comment:11 Changed 9 years ago by
Milestone: | sage-6.2 → sage-6.3 |
---|
comment:12 Changed 8 years ago by
Milestone: | sage-6.3 → sage-6.4 |
---|
comment:13 Changed 2 years ago by
Milestone: | sage-6.4 → sage-duplicate/invalid/wontfix |
---|---|
Reviewers: | → Dima Pasechnik |
Status: | needs_work → positive_review |
outdated
comment:14 Changed 18 months ago by
Resolution: | → invalid |
---|---|
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Before
After
That's another quarter-second (12.5%) savings.