Opened 11 years ago

Last modified 9 years ago

#11026 closed enhancement

Add double clicking of sws files for Mac app — at Version 13

Reported by: iandrus Owned by: iandrus
Priority: major Milestone: sage-5.8
Component: user interface Keywords: mac app
Cc: kcrisman, jhpalmieri Merged in:
Authors: Ivan Andrus Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #8473, #13121 Stopgaps:

Status badges

Description (last modified by kcrisman)

With #8473 we have the necessary support for uploading files. This allows the Mac app to support double clicking of sws files. Also able to be opened are txt and zip files.


Apply trac_11026-extcode-rebase.patch to the extcode repository.

Change History (14)

comment:1 Changed 11 years ago by kcrisman

  • Cc kcrisman added

comment:2 Changed 11 years ago by kcrisman

I think the patch already exists, right? You could just add it and mark 'needs review'.

comment:3 Changed 11 years ago by iandrus

  • Owner changed from was to iandrus

comment:4 Changed 11 years ago by iandrus

  • Status changed from new to needs_review

comment:5 Changed 10 years ago by kcrisman

This would eventually need also to add html (#10652) and other file types as possible uploads, but I think that those could be additional enhancements to the Mac app.

I have to admit that some of the stuff in designable.nib I will never understand. I see the "new option to automatically start the server when a sws file is opened" from #8473, but some of the things like "IBConnectionRecord" and the mysterious numbers everywhere I can only judge by their effects. I am impressed by all the work bringing the double-click not just to the browser but to the mini-browser you built.

I'll be testing this shortly.

comment:6 Changed 10 years ago by kcrisman

I get a weird error, perhaps related to the problems with browsers at #8473, with this:

The resource /upload_worksheet?url=file://localhost/Users/student/Desktop/Tests.sws cannot be found.

Notice the file://localhost/Users rather than file:///Users which we get at #8473.

comment:7 Changed 10 years ago by kcrisman

From #8473:

The Mac app has a new option to automatically start the server when a sws file is opened. I'm not sure anyone would ever want to turn this off, so I can remove it if it's not useful.

But it does work as advertised. I can imagine one wanting to avoid 'accidentally' starting the server, so let's keep it.

The rest seems to work as it's supposed to, modulo the issues mentioned at #8473.

comment:8 Changed 10 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman

Here's a couple more interesting details.

  • Changing the default browser to FF, it still worked! Even if the server was started.
  • BUT if the app was completely turned off, then I got the message about the following not being found - no surprise, as port 0 probably is not open!
    http://localhost:0/upload_worksheet?url=file://localhost/Users/karl-dietercrisman/Desktop/Test.sws
    
    That is certainly some kind of residue from #8473, with somehow the initial port 0 not being changed soon enough or something. You could follow up there if it makes more sense.

comment:9 Changed 10 years ago by kcrisman

Separately, I just experienced the phenomenon of closing the app turning off a different Sage server session! At least that's what it seemed like.

comment:10 Changed 10 years ago by kcrisman

I also get a strange 'doubling' of the pages just now - not before. I'm not sure what's causing it, but somehow it's opening two copies of the loading page, etc. I'm getting port 8001 right now, so maybe that's it.

Now it seems to be more normal again, though I still got two copies of the worksheet, presumably from your !URLQueue. Anyway, not something I'm really concerned with, since it's working nonetheless.

comment:11 Changed 10 years ago by kcrisman

  • Status changed from needs_review to needs_work

Putting to 'needs work'.

  • At least it should work with #8473.
  • The port 0 thing should probably work.
  • The other stuff isn't as important. Probably needs a little more testing in any case, but the concept is more than proven.

comment:12 Changed 10 years ago by kcrisman

  • Status changed from needs_work to needs_info

#8473 is solved, see the sagenb upstream pull request.

Putting this to "needs info" because I don't know whether this patch will be compatible with the new notebook.

Changed 10 years ago by kcrisman

Based on 5.1beta1

comment:13 Changed 10 years ago by kcrisman

  • Dependencies set to #8473, #13121
  • Description modified (diff)
  • Status changed from needs_info to needs_review

I just rebased this, because of a slight change when sage-env was moved. Shouldn't have any other new notebook problems, see comment:12:ticket:10556. Now it's time to look at it!

Dependencies include #13121, where #8473 will eventually live.

Apply trac_11026-extcode-rebase.patch to the extcode repository.

Note: See TracTickets for help on using tickets.