Opened 9 years ago

Last modified 8 years ago

#11021 closed defect

clean up sage-spkg — at Version 3

Reported by: jhpalmieri Owned by: tbd
Priority: major Milestone: sage-5.3
Component: packages: standard Keywords: SPKG.txt SAGE.txt -info BUILD sage-env sage-sage sage-spkg
Cc: drkirkby, leif, fbissey Merged in:
Authors: Leif Leonhardy Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ltw)

One of the patches at #9960 did a lot of clean-up to the file sage-spkg: quoting environment variables, replacing tabs with spaces, etc. Since those changes were not related to the issue at #9960, I've split them off and put them here instead. The main change of any content is to look at the file SPKG.txt rather than SAGE.txt when the "-info" flag is passed so sage-spkg.

Apply:

  1. trac_11021-sage-spkg-cleanup-v2.patch

Change History (3)

comment:1 Changed 9 years ago by jhpalmieri

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by ltw

Patch has been rebased to sage 4.7. However, there is a problem on lines 136-143 in sage-spkg (after patch has been applied). The return code check doesn't do anything after the statement echo "", because that overwrites $? to 0. I can't figure out the intent of the preceding tar command, so I don't know how to fix this problem. Could someone help me?

comment:3 Changed 9 years ago by ltw

  • Description modified (diff)
Note: See TracTickets for help on using tickets.