Opened 8 years ago

Last modified 5 years ago

#11017 needs_info defect

GP blocks files when reallocating memory; Workaround

Reported by: mraum Owned by: was
Priority: major Milestone: sage-6.4
Component: interfaces Keywords:
Cc: Merged in:
Authors: Martin Raum Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mraum)

If a request in _eval_line of the gp interface cannot be executed due to lack of stack memory, the tmp file used to transfer results is blocked.

This is a workaround. We simple create a new file and trust in the system when it comes to cleaning the environement after GP has terminated.

See #11018 for a ticket for removing this workaround after finding a better solution (without reevaluating the GP code!)

Attachments (1)

trac-11017-gp_file_block.patch​ (1.6 KB) - added by mraum 8 years ago.

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by mraum

comment:1 Changed 8 years ago by mraum

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 follow-up: Changed 8 years ago by cremona

The patch looks ok -- testing now.

comment:3 in reply to: ↑ 2 Changed 8 years ago by cremona

  • Reviewers set to John Cremona
  • Status changed from needs_review to positive_review

Replying to cremona:

The patch looks ok -- testing now.

All tests pass, so positive review (and on to #11024)

comment:4 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_info

Please give an example of the problem that this ticket is addressing.

comment:5 Changed 8 years ago by mraum

A typical example is Dokchitser calculator, that can easily provoke a stack overflow in GP. Then the stack will be increase but the temporary file cannot be read anymore. More specifically, the test on line 760 after applying trac-11024-dokchitser.patch fails for this very reason.

comment:6 Changed 8 years ago by jdemeyer

Allright, I will have a look and try to understand the problem.

comment:7 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:9 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:10 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4
Note: See TracTickets for help on using tickets.