Opened 8 years ago

Closed 6 years ago

#11009 closed enhancement (invalid)

Notebook keybindings should be configurable

Reported by: iandrus Owned by: jason, mpatel, was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords: keybinding
Cc: boothby Merged in:
Authors: Reviewers: Ivan Andrus
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I am of the opinion that control-backspace should delete the previous word. Since this is what it does everywhere else on my system, I constantly find myself combining notebook cells that have no business being combined. All in all it would be nice to have some way to customize the keybindings in the notebook (ideally per user).

Attachments (1)

trac_11009-sagenb.patch (1.5 KB) - added by iandrus 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by iandrus

comment:1 Changed 8 years ago by iandrus

  • Authors set to Ivan Andrus
  • Status changed from new to needs_review

Until the day of enlightenment comes we can at least execute a config file in DOT_SAGE which allows customization via something like

js.keyhandler.key_codes['join_cell']=[]
js.keyhandler.add('join_cell', key = "KEY_BKSPC", alt=True)

Tom, William said that you knew about this part of the code and so if there is a better way to do this, don't hesitate to make me change it.

comment:2 follow-up: Changed 8 years ago by boothby

This is essentially the use case we planned on. My only complaint is that the format of .keys is a bit obnoxious, and this utterly lacks the documentation necessary to make it configurable.

A preferable alternative is to implement a keybinding portion of user preferences. Unfortunately, the specific order that keybindings are tested in is highly sensitive to the keys that are pressed.

comment:3 in reply to: ↑ 2 Changed 8 years ago by iandrus

Replying to boothby:

This is essentially the use case we planned on. My only complaint is that the format of .keys is a bit obnoxious, and this utterly lacks the documentation necessary to make it configurable.

I realize my patch is crappy :-) It was the bare minimum that I could figure out. I'm happy to add documentation and make the keys file more sane if that's a good approach.

A preferable alternative is to implement a keybinding portion of user preferences. Unfortunately, the specific order that keybindings are tested in is highly sensitive to the keys that are pressed.

I'm not familiar with the notebook at all. How difficult would this be and where would I begin? Or should I let an expert do it?

comment:4 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.7 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

I think this should be closed since the notebook is now a separate project and in any case, there is work on a completely new frontend.

comment:5 Changed 6 years ago by jdemeyer

  • Authors Ivan Andrus deleted
  • Resolution set to invalid
  • Reviewers set to Ivan Andrus
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.