Opened 10 years ago
Closed 10 years ago
#11004 closed enhancement (fixed)
Make subdivisions optional on tensor product of matrices
Reported by: | rbeezer | Owned by: | jason, was |
---|---|---|---|
Priority: | trivial | Milestone: | sage-4.7 |
Component: | linear algebra | Keywords: | matrix tensor product subdivision |
Cc: | jhpalmieri | Merged in: | sage-4.7.alpha4 |
Authors: | Rob Beezer | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Apply: trac_11004-tensor-product-subdivision-v2.patch
Attachments (2)
Change History (7)
comment:1 Changed 10 years ago by
- Cc jhpalmieri added
- Status changed from new to needs_work
comment:2 Changed 10 years ago by
- Status changed from needs_work to needs_review
The one patch here is now ready to go, despite the (old) comment on it.
comment:3 Changed 10 years ago by
- Keywords matrix tensor product subdivision added
- Reviewers set to John Palmieri
- Status changed from needs_review to positive_review
Looks good to me. I might change the phrase "The subdivisions that are provided automatically will partition ..." to "By default, the matrix will be subdivided ...". If you feel like making that change, it won't require a new review.
Changed 10 years ago by
comment:4 Changed 10 years ago by
- Description modified (diff)
Thanks for the suggestion, John. I wrote that a couple of times and wasn't happy with it. v2 patch has the suggested change.
comment:5 Changed 10 years ago by
- Merged in set to sage-4.7.alpha4
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
This is not quite ready, but a functional patch with most of the content is available - more later.