Opened 9 years ago
Closed 9 years ago
#10987 closed enhancement (fixed)
Add optional arguement to decomposition_of_subspace making restrict not check the subspace
Reported by: | mraum | Owned by: | Martin Raum |
---|---|---|---|
Priority: | major | Milestone: | sage-4.7 |
Component: | linear algebra | Keywords: | decomposition |
Cc: | mraum@… | Merged in: | sage-4.7.alpha5 |
Authors: | Martin Raum | Reviewers: | Rob Beezer |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Add an optional arguement to the decomposition of subspaces, that we can call when computing the decomposition of Hecke modules.
Apply:
Attachments (2)
Change History (8)
comment:1 Changed 9 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
Passes all tests and looks good.
Two documentation suggestions.
- "withour" is mis-spelled.
- Now that there is an INPUT block, perhaps you can move the information about
kwds
down as a formal part of that block.
Changed 9 years ago by
Changed 9 years ago by
comment:4 Changed 9 years ago by
- Description modified (diff)
comment:5 Changed 9 years ago by
- Reviewers set to Rob Beezer
- Status changed from needs_review to positive_review
All looks good, passes tests, documentation builds. Positive review.
comment:6 Changed 9 years ago by
- Merged in set to sage-4.7.alpha5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
This passed all long tests for me, I'll look closer in the morning.