Opened 8 years ago

Closed 8 years ago

#10987 closed enhancement (fixed)

Add optional arguement to decomposition_of_subspace making restrict not check the subspace

Reported by: mraum Owned by: Martin Raum
Priority: major Milestone: sage-4.7
Component: linear algebra Keywords: decomposition
Cc: mraum@… Merged in: sage-4.7.alpha5
Authors: Martin Raum Reviewers: Rob Beezer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mraum)

Add an optional arguement to the decomposition of subspaces, that we can call when computing the decomposition of Hecke modules.

Apply:

  1. trac-10987-decomposition_of_subspaces.patch​
  2. trac-10987-decomposition_of_subspaces-2.patch​

Attachments (2)

trac-10987-decomposition_of_subspaces.patch​ (1.8 KB) - added by mraum 8 years ago.
trac-10987-decomposition_of_subspaces-2.patch​ (950 bytes) - added by mraum 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by mraum

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by rbeezer

This passed all long tests for me, I'll look closer in the morning.

comment:3 Changed 8 years ago by rbeezer

Passes all tests and looks good.

Two documentation suggestions.

  1. "withour" is mis-spelled.
  1. Now that there is an INPUT block, perhaps you can move the information about kwds down as a formal part of that block.

Changed 8 years ago by mraum

Changed 8 years ago by mraum

comment:4 Changed 8 years ago by mraum

  • Description modified (diff)

comment:5 Changed 8 years ago by rbeezer

  • Reviewers set to Rob Beezer
  • Status changed from needs_review to positive_review

All looks good, passes tests, documentation builds. Positive review.

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.