Overhaul matrix stack, augment

[rbeezer]

This patch overhauls, consolidates, fixes and expands matrix augmentation and stacking.

Fixes:

• subdivisions of matrices are generally not preserved under these operations, but now are

Features:

• a vector may now be supplied as a second argument across all routines

Consolidation:

• there is some standardization of variable names and techniques across the routines

Expansion:

• augment() for dense integer matrices is uncommented and working now

Documentation:

• new features (vector argument, subdivisions) have been documented where added
• a general upgrade in documentation would be valuable, on another ticket

To Do:

• work to have result formed over a common ring

"general" patch adds vector argument and subdivision support to the generic stack() method. Subdivision management is split out as helper methods for use with routines in the "special" patch.

"special" patch works on routines for dense integer matrices, mod 2 matrices, and generic sparse matrices. It also moves the generic matrix augment() to a better location in the source (it was left in place so changes could be seen more readily on the "general" patch).

Apply:

1. trac_10974_stack-augment-general.patch​
2. trac_10974_stack-augment-special.patch​
3. trac_10974_stack-augment.reviewer-v2.patch​

[kini]

Three doctests failed on sage.math. I reran them and they failed to fail (one of them was devel/sage/sage/tests/startup.py ), so everything looks good. I did some minor formatting to keep line lengths down according to PEP 8 and will attach a reviewer patch accordingly, but feel free to veto it. Positive review!

[kini]

line wrapping

[kini]

(for patchbot)

[rbeezer]

Keshav,

Thanks for the review! The changes look good - thanks for those as well.

Rob

[jdemeyer]

Change the commit message of the last patch such that it contains the ticket number.

[rbeezer]

Commit message fixed in v2 version of reviewer patch.

[jdemeyer]

This patch conflicts with #4983.

[jhpalmieri]

Let's leave this one alone. I'll rebase #4983. I'm setting this back to "positive review".