Changes between Initial Version and Version 19 of Ticket #10973


Ignore:
Timestamp:
11/23/11 14:38:14 (11 years ago)
Author:
cremona
Comment:

Positive review. In my reviewer's patch I fix the following:

  1. Now applies to 4.7.2 with no fuzz.
  2. Added QQ to import list on line 332 of ell_number_field.py, otherwise testing ell_int_pts failed, but testing ell_number_field did not -- since the test for that function silverman_height_bounds was incomplete! I fixed that too.
  3. Fixed a warning in docbuild by adding a blank line at line 69 of the same file.

It is now true that for an elliptic curve E over Q we have both the new E.silverman_height_bounds(), which gives lower and upper bounds, and the old E.silverman_height_bound(), which only gives one of them. The latter can be deleted but that will require some tweaking of any code which uses it. I have left that for another ticket.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10973

    • Property Status changed from new to positive_review
    • Property Authors changed from Justin Walker to Justin Walker, Aly Deines, Jennifer Balakrishnan
    • Property Cc gagansekhon jen added
    • Property Keywords sd32 added
    • Property Type changed from PLEASE CHANGE to enhancement
  • Ticket #10973 – Description

    initial v19  
    11Incorporate work done by Rado Kirov and Jackie Anderson at Sage Days 22, based on Magma implementation by Cremona's student Nook.
    22
     3Apply only Trac10973.7.patch