Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#10966 closed enhancement (fixed)

Make it impossible for unprivileged trac users to close tickets

Reported by: mderickx Owned by: mvngu, schilly
Priority: major Milestone: sage-4.7
Component: website/wiki Keywords:
Cc: Merged in: sage-4.7.rc0
Authors: Maarten Derickx Reviewers: Keshav Kini
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by kini)

In several places in the documentation it says you shouldn't close tickets if you aren't a release manager. Since it's so trivial to fix maybe we should change the rights needed to change the status of a ticket in order to prevent unknown people from closing tickets. According to the trac wiki this can be done by changing close.permissions = TICKET_MODIFY to close.permissions = TICKET_ADMIN in the trac.ini file. Of course TICKET_ADMIN could be anything logical from the possible permission set.

We could even do more fancy stuff like add a "nominate for closure" status to the workflow or a "request patchbot" and a "patchbot doctest passed" depending on how the development workflow is in real life.

Attachments (1)

doc-closing-tickets.patch (2.1 KB) - added by mderickx 11 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 11 years ago by mderickx

  • Authors set to Maarten Derickx
  • Status changed from new to needs_review

I changed the trac config so that closing should not be possible anymore. So test and review :)

comment:2 Changed 11 years ago by mderickx

At least not when you don't have TICKET_ADMIN right's if you have TICKET_ADMIN or something higher like TRAC_ADMIN it is still possible.

comment:3 Changed 11 years ago by mderickx

  • Status changed from needs_review to needs_work

Changed 11 years ago by mderickx

comment:4 Changed 11 years ago by mderickx

  • Status changed from needs_work to needs_review

comment:5 Changed 11 years ago by kini

  • Description modified (diff)
  • Reviewers set to Keshav Kini
  • Status changed from needs_review to positive_review
  • Summary changed from Make it impossible for unpiviliged trac users to close tickets to Make it impossible for unprivileged trac users to close tickets

Looks good. I can't close tickets, and the documentation builds fine. I successfully added a dependency to #11120. Positive review!

comment:6 Changed 11 years ago by jdemeyer

  • Milestone set to sage-4.7

comment:7 Changed 11 years ago by jdemeyer

It's not a major problem, but it is nice if the filename of a patch contains the ticket number (mainly to ensure no two patches from different tickets have the same filename).

comment:8 Changed 11 years ago by jdemeyer

  • Merged in set to sage-4.7.rc0

Seems I am still an "unprivileged trac user", so I cannot close tickets, I sent an email to William about this. Anyway, this one can be closed.

comment:9 Changed 11 years ago by mderickx

  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 follow-up: Changed 11 years ago by mderickx

Hej Jeroen, Are you sure you cannot close tickets. I looked at the permissions and we have exactly the same permissions, yet I was able to close this ticket. (This is also how I tested if you would still be able to close tickets, since that would be very! important)

Kind Regards

comment:11 in reply to: ↑ 10 Changed 11 years ago by jdemeyer

Replying to mderickx:

Hej Jeroen, Are you sure you cannot close tickets.

Did the procedure for closing tickets change?

I do not see "resolve as..." in the Actions box on the bottom of a ticket webpage.

I am using Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.16) Gecko/20110420 Gentoo Firefox/3.6.16 if that is relevant.

comment:12 follow-up: Changed 11 years ago by mderickx

The procedure is exactly the same, only the permissions needed to do certain things have been changed. I set the closing of tickets to require "TICKET_ADMIN" rights. After looking a bit more carefull at http://trac.sagemath.org/sage_trac/admin/general/perm I saw that the person who gave you administrative rights on trac made a small error. The account jdmeyer had TRAC_ADMIN as rights. I changed it to jdemeyer. I hope you can now close tickets again. (ps. you should now also see an admin button on trac.

comment:13 in reply to: ↑ 12 Changed 11 years ago by jdemeyer

Replying to mderickx:

The account jdmeyer had TRAC_ADMIN as rights. I changed it to jdemeyer. I hope you can now close tickets again. (ps. you should now also see an admin button on trac.

Bedankt!

Note: See TracTickets for help on using tickets.