Opened 8 years ago

Closed 8 years ago

#10961 closed enhancement (fixed)

Add Lie bracket operation in Rings()

Reported by: nthiery Owned by: AlexGhitza
Priority: major Milestone: sage-4.7.1
Component: algebra Keywords:
Cc: Merged in: sage-4.7.1.alpha0
Authors: Nicolas M. Thiéry Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by aschilling)

From the documentation:

    sage: F = AlgebrasWithBasis(QQ).example(); F
    An example of an algebra with basis: the free algebra on the generators ('a', 'b', 'c') over Rational Field
    sage: a,b,c = F.algebra_generators()
    sage: F.bracket(a,b)
    B[word: ab] - B[word: ba]

Apply trac_10961-lie_bracket_in_rings-nt.patch

Attachments (2)

wifi (17 bytes) - added by nthiery 8 years ago.
Please delete this file!
trac_10961-lie_bracket_in_rings-nt.patch (1.5 KB) - added by nthiery 8 years ago.
Final version

Download all attachments as: .zip

Change History (10)

comment:1 follow-up: Changed 8 years ago by aschilling

  • Reviewers set to Anne Schilling
  • Status changed from new to needs_work

The patch implements the Lie bracket and it would be good to merge it into sage soon. However, the tests in /categories/rings.py line 70 do not pass due to the misprint {{

sage: a,b,c = FF.algebra_generators()

}} should be {{

sage: a,b,c = F.algebra_generators()

}}

comment:2 in reply to: ↑ 1 Changed 8 years ago by nthiery

  • Status changed from needs_work to needs_review
  • Summary changed from Add Lie bracket operation in Rings to Add Lie bracket operation in Rings()

Replying to aschilling:

The patch implements the Lie bracket and it would be good to merge it into sage soon. However, the tests in /categories/rings.py line 70 do not pass due to the misprint {{

sage: a,b,c = FF.algebra_generators()

}} should be {{

sage: a,b,c = F.algebra_generators()

}}

Shoot; I had noticed this, and got distracted. Thanks for the reminder! Fixed!

Changed 8 years ago by nthiery

Please delete this file!

Changed 8 years ago by nthiery

Final version

comment:3 Changed 8 years ago by nthiery

  • Description modified (diff)

comment:4 Changed 8 years ago by aschilling

  • Status changed from needs_review to positive_review

Looks good!

comment:5 Changed 8 years ago by nthiery

Thanks for the review!

comment:6 Changed 8 years ago by aschilling

  • Description modified (diff)

comment:7 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-4.7 to sage-4.7.1

comment:8 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.1.alpha0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.