Opened 10 years ago

Closed 9 years ago

#10959 closed defect (fixed)

BipartiteGraph adding edges between new nodes ignores partition

Reported by: rhinton Owned by: rhinton
Priority: major Milestone: sage-5.0
Component: graph theory Keywords: bipartite graph
Cc: brunellus, jason Merged in: sage-5.0.beta2
Authors: Lukáš Lánský Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

For example,

sage: bg = BipartiteGraph()
sage: bg.add_edge(0,1)
sage: bg.left
set([])
sage: bg.right
set([])

Note that we can't really tell in general what the proper partitions for these new vertices are. We can if *one* exists already. The easy out in the former case is to throw an error.

There was some previous discussion about deciding partitions automatically. Volunteers are welcome. In the mean time, we should at least throw an error to avoid an invalid state.

Attachments (1)

Trac_10959_add_edge_handles_partitions.patch (2.3 KB) - added by brunellus 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by brunellus

  • Cc brunellus added

comment:2 Changed 10 years ago by jason

  • Cc jason added

comment:3 Changed 10 years ago by brunellus

  • Status changed from new to needs_review

I think this is much simpler problem than #8744 -- no computationally expensive step is required to automatically add new vertex or vertices to the partitions.

Changed 10 years ago by brunellus

comment:4 Changed 9 years ago by ncohen

  • Status changed from needs_review to positive_review

Hmmmmm ^^;

Methinks this class really is a mess, but you did what made the most sense in this context ^^;

Good to go ! Thank you for this patch ! :-)

Nathann

comment:5 Changed 9 years ago by jdemeyer

  • Authors set to Lukáš Lánský
  • Reviewers set to Nathann Cohen

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.