id,summary,reporter,owner,description,type,status,priority,milestone,component,resolution,keywords,cc,merged,author,reviewer,upstream,work_issues,branch,commit,dependencies,stopgaps
10945,Fix lots of minor docs and redundancy for riemann.pyx,kcrisman,burcin,"The Riemann mapping stuff is a great addition - excellent work!
But there are lots of minor problems that should be fixed. Here are some. Closing this ticket wouldn't require fixing them all, but if not, then explanations should be provided here and followup tickets (if needed) opened.
* Awkward phrasing:
{{{
Note that all the methods are numeric rather than analytic, for unusual
regions or insufficient collocation points may give very inaccurate
results.
}}}
This is hard to follow, though I see what it says.
* There is also a 'reimann' several times, and a 'correspondance'.
* This also seems to have a transposition in how it's put in. Presumably the redefinition of `I` is supposed to demonstrate it works with lots of different complex types. I suggest the following.
{{{
Can work for different types of complex numbers::
sage: m = Riemann_Map([lambda t: e^(I*t) - 0.5*e^(-I*t)], [lambda t: I*e^(I*t) + 0.5*I*e^(-I*t)], 0) # long time (4 sec)
sage: m.riemann_map(0.25 + sqrt(-0.5)) # long time
(0.137514137885...+0.876696023004...j)
+ sage: I = CDF.gen() # long time
sage: m.riemann_map(1.3*I) # long time
(-1.561029396...+0.989694535737...j)
- sage: I = CDF.gen() # long time
sage: m.riemann_map(0.4) # long time
}}}
* Add any information at all about theoretical error bounds, if known. Since not everyone will be able to just look up that paper referenced, it would be helpful to have at least order of magnitude ideas (e.g., if N=2000 on a map from the unit circle to itself, we expect errors no greater than epsilon=blah).
* From #8867: ""It now properly avoids failing with lambda functions, although it doesn't work optimally for them. I'll add some notes on that in #10945.""",defect,closed,minor,sage-duplicate/invalid/wontfix,calculus,duplicate,riemann map complex plot,evanandel jason wdj mvngu,,,Karl-Dieter Crisman,N/A,,,,,