Opened 10 years ago

Closed 10 years ago

#10921 closed enhancement (fixed)

Commutator subgroup for permutation groups

Reported by: rbeezer Owned by: joyner
Priority: minor Milestone: sage-4.7
Component: group theory Keywords:
Cc: dimpase Merged in: sage-4.7.alpha3
Authors: Rob Beezer Reviewers: Dmitrii Pasechnik, David Joyner
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Wraps GAP's CommutatorSubgroup and DerivedSubgroup.

Attachments (1)

trac_10921-commutator-permutation-groups.patch (4.0 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc dimpase added
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by wdj

This applies fine to 4.6.2.a1. It passes sage -testall except for an unrelated failure in the R interface module. As far as I can see, the code and docstrings look very good.

I'm going to test it on another machine.

comment:3 Changed 10 years ago by rbeezer

If this does not apply properly, try 4.7.alpha1, plus #10871, #10920, where I have checked that it does apply.

comment:4 Changed 10 years ago by dimpase

  • Status changed from needs_review to positive_review

Works! Positive review.

comment:5 Changed 10 years ago by rbeezer

  • Reviewers set to Dmitrii Pasechnik, David Joyner

comment:6 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.