Opened 10 years ago

Closed 10 years ago

#10920 closed enhancement (fixed)

Conjugates of permutation groups

Reported by: rbeezer Owned by: joyner
Priority: minor Milestone: sage-4.7
Component: group theory Keywords:
Cc: dimpase Merged in: sage-4.7.alpha3
Authors: Rob Beezer Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by rbeezer)

Patch wraps GAP's "ConjugateSubgroup" function.

Apply trac_10920-conjugates-permutation-groups-v2.patch

Depends #10871

Attachments (2)

trac_10920-conjugates-permutation-groups.patch (3.6 KB) - added by rbeezer 10 years ago.
trac_10920-conjugates-permutation-groups-v2.patch (3.7 KB) - added by rbeezer 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by rbeezer

  • Authors set to Rob Beezer
  • Cc dimpase added
  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by dimpase

  • Status changed from needs_review to needs_info

Hi, the patch applies and works, although with fuzz (due to your older patches for sage/groups/perm_gps/permgroup.py, I presume).

I don't know, perhaps you should think of rebasing it so that all your recent patches for permgroup.py apply one after another without a problem?

Dima

comment:3 in reply to: ↑ 2 Changed 10 years ago by rbeezer

Replying to dimpase:

I don't know, perhaps you should think of rebasing it so that all your recent patches for permgroup.py apply one after another without a problem?

Yes, I should. I was not very careful about how I stacked them, since I didn't want to have a long list of dependencies for reviewers. But I do need to get things organized so the release manager can apply them without problems, as well.

I'm away most of today, but will get this one fixed and make #10921 follow it.

Thanks, Rob

comment:4 follow-up: Changed 10 years ago by rbeezer

  • Description modified (diff)
  • Status changed from needs_info to needs_review

v2 patch is rebased to apply to 4.7.alpha1, plus #10871.

comment:5 in reply to: ↑ 4 Changed 10 years ago by dimpase

  • Status changed from needs_review to positive_review

Replying to rbeezer:

v2 patch is rebased to apply to 4.7.alpha1, plus #10871.

OK, applies and works just fine. Positive review.

comment:6 Changed 10 years ago by rbeezer

  • Reviewers set to Dmitrii Pasechnik

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.