Opened 8 years ago

Closed 8 years ago

#10900 closed enhancement (fixed)

100% coverage in graph directory

Reported by: ncohen Owned by: mvngu
Priority: major Milestone: sage-4.7
Component: documentation Keywords:
Cc: rlm Merged in: sage-4.7.alpha2
Authors: Nathann Cohen, Robert Miller Reviewers: Robert Miller, Nathann Cohen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Only 4 methods to go, and this patches give 100% of doctest coverage for the graph/ folder !

Nathann

Attachments (2)

trac_10900.patch (7.4 KB) - added by ncohen 8 years ago.
trac_10900-part2.patch (7.3 KB) - added by rlm 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by ncohen

Changed 8 years ago by rlm

comment:1 Changed 8 years ago by rlm

  • Authors set to Nathann Cohen, Robert Miller
  • Status changed from new to needs_review

Uncovered and fixed a bug while writing these doctests... :)

comment:2 Changed 8 years ago by ncohen

Well, if you review mine I can review yours ? :-)

Nathann

comment:3 Changed 8 years ago by rlm

Yours looks good to me!

comment:4 Changed 8 years ago by ncohen

  • Status changed from needs_review to positive_review

Then it's good to go :-)

base/graph_backends.py: 100% (57 of 57)
base/sparse_graph.pyx: 100% (27 of 27)
base/dense_graph.pyx: 100% (21 of 21)
base/c_graph.pyx: 100% (45 of 45)
bipartite_graph.py: 100% (16 of 16)
chrompoly.pyx: 100% (1 of 1)
cliquer.pyx: 100% (4 of 4)
digraph.py: 100% (39 of 39)
digraph_generators.py: 100% (8 of 8)
dot2tex_utils.py: 100% (6 of 6)
generic_graph.py: 100% (218 of 218)
generic_graph_pyx.pyx: 100% (16 of 16)
genus.pyx: 100% (4 of 4)
graph.py: 100% (48 of 48)
graph_bundle.py: 100% (5 of 5)
graph_coloring.py: 100% (14 of 14)
graph_database.py: 100% (14 of 14)
graph_editor.py: 100% (2 of 2)
graph_generators.py: 100% (94 of 94)
graph_latex.py: 100% (12 of 12)
graph_list.py: 100% (7 of 7)
graph_plot.py: 100% (9 of 9)
linearextensions.py: 100% (7 of 7)
matchpoly.pyx: 100% (2 of 2)
modular_decomposition/modular_decomposition.pyx: 100% (1 of 1)
planarity.pyx: 100% (1 of 1)
pq_trees.py: 100% (15 of 15)
print_graphs.py: 100% (5 of 5)
schnyder.py: 100% (8 of 8)
spanning_tree.pyx: 100% (1 of 1)
trees.pyx: 100% (4 of 4)

Overall weighted coverage score:  100.0%
Total number of functions:  711

Nathann

comment:5 Changed 8 years ago by jdemeyer

  • Reviewers set to Robert Miller, Nathann Cohen

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.7.alpha2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.